8000 BUG: fix np.save issue with python 2.7.5 by pnbat · Pull Request #10524 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: fix np.save issue with python 2.7.5 #10524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 5, 2018
Merged

BUG: fix np.save issue with python 2.7.5 #10524

merged 2 commits into from
Feb 5, 2018

Conversation

pnbat
Copy link
Contributor
@pnbat pnbat commented Feb 5, 2018 •
edited by charris
Loading

Workaround for the tokenizer issue with python 2.7.5. Closes #10348.

@pnbat pnbat mentioned this pull request Feb 5, 2018
Closed
@charris charris added this to the 1.14.1 release milestone Feb 5, 2018
@eric-wieser
Copy link
Member
eric-wieser commented Feb 5, 2018 •
edited
Loading

Can you elaborate on the read → readline change?

@charris
Copy link
Member
charris commented Feb 5, 2018

@eric-wieser

tokenize.generate_tokens(readline)
The generate_tokens() generator requires one argument, readline, which must be a callable object which provides the same interface as the readline() method of built-in file objects (see section File Objects). Each call to the function should return one line of input as a string. Alternately, readline may be a callable object that signals completion by raising StopIteration.

@charris charris merged commit 1ba96c6 into numpy:master Feb 5, 2018
@charris
Copy link
Member
charris commented Feb 5, 2018

I think this is OK. Thanks @pnbat .

@pnbat
Copy link
Contributor Author
pnbat commented Feb 5, 2018

Maybe changing to readline would have been sufficient. I could elaborate on that during the refactorings...
I also hope that the unit tests are tight :)

@charris
Copy link
Member
charris commented Feb 5, 2018

@pnbat The thought crossed my mind, but after looking at the Python fix I thought probably not. Be interesting to see if that is the case though.

@pnbat pnbat deleted the bugfix branch February 6, 2018 03:32
@charris charris mentioned this pull request Feb 7, 2018
Merged
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label Feb 7, 2018
@dsindex dsindex mentioned this pull request Apr 3, 2018
Closed
@charris charris mentioned this pull request Aug 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
00 - Bug component: numpy.lib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pnbat @eric-wieser @charris
0