BUG: Fix strange behavior of infinite-step-size/underflow-case in arange #10263
Add
PyObject_RichCompareBool success check
- Loading branch information
commit d68afb36dd37ca9d8ed8604830cf8e5c2b14a94d
Ther 8000 e are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3105,6 +3105,12 @@ _calc_length(PyObject *start, PyObject *stop, PyObject *step, PyObject **next, i | |
| } | ||
|
|
||
| next_is_nonzero = PyObject_RichCompareBool(*next, zero, Py_NE); | ||
| if (next_is_nonzero == -1) { | ||
| Py_DECREF(zero); | ||
| Py_DECREF(*next); | ||
| *next = NULL; | ||
| return -1; | ||
| } | ||
| val = PyNumber_TrueDivide(*next, step); | ||
| Py_DECREF(*next); | ||
| *next = NULL; | ||
|
|
@@ -3116,6 +3122,10 @@ _calc_length(PyObject *start, PyObject *stop, PyObject *step, PyObject **next, i | |
|
|
||
| val_is_zero = PyObject_RichCompareBool(val, zero, Py_EQ); | ||
|
There was a problem hiding this comment. Should be an There was a problem hiding this comment. You need to check that this doesn't return -1, indicating an error occurred. Same above. |
||
| Py_DECREF(zero); | ||
| if (val_is_zero == -1) { | ||
| Py_DECREF(val); | ||
| return -1; | ||
| } | ||
|
|
||
| if (cmplx && PyComplex_Check(val)) { | ||
|
There was a problem hiding this comment. Trying to work out if this section needs a fix too, but I can't work out what this is even trying to do. There was a problem hiding this comment. @eric-wieser Me too. I don't know why the complex case exists. This is none-sense as math. |
||
| value = PyComplex_RealAsDouble(val); | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could use
PyObject_IsTrue, but that might be worse on unusual typesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eric-wieser IMO,
PyObject_RichCompareBoolis better because this is clear what we do.