BUG: Extra space is inserted on first line for long elements #10182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
commented
Dec 9, 2017
| * For line-wrapping: | ||
|
|
||
| * The "dtype" part of ndarray reprs will now be printed on the next line | ||
| if there isn't space on the last line of array output. | ||
| * The ``linewidth`` format option is now always respected. | ||
| The `repr` or `str` of an array will never exceed this, unless a single | ||
| element is too wide. | ||
| * All but the last line of array strings will contain the same number of | ||
| elements. |
There was a problem hiding this comment.
This is only a change in extremely contrived scenarios (custom separators), so probably doesn't belong here.
|
LGTM. |
eric-wieser
commented
Dec 9, 2017
numpy/core/arrayprint.py
Outdated
| if len(line) + len(word) > line_width: | ||
| def _extendLine(s, line, word, line_width, next_line_prefix, legacy): | ||
| needs_wrap = len(line) + len(word) > line_width | ||
| if legacy != '1.13' and len(line) == len(next_line_prefix): |
There was a problem hiding this comment.
I suppose strictly this should be <=, but in practice that never happens
There was a problem hiding this comment.
Sure you don't want to change it before this goes in?
There was a problem hiding this comment.
Guess I will. Updated
e4aa8e3 to
c9052f0
Compare
|
Thanks Eric. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-10181
Also strip some trailing spaces added by the web editor in the release notes.