MAINT: Fix test_int_from_huge_longdouble on Darwin. #10000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was failing on Darwin due to Apple's defective pow function. The fix here is to generate the huge longdouble that is tested in a way that avoids the problems of the pow function. The C++ comments in npy_longdouble.c are also fixed.
|
Thanks! |
|
Belated 🎉 🎉 - issue 10000! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was failing on Darwin due to Apple's defective pow function.
The fix here is to generate the huge longdouble that is tested in a way
that avoids the problems of the pow function.
The C++ comments in npy_longdouble.c are also fixed.
The fix has been tested on a Mac.