8000 Ufunc override should normalize the sig keyword argument · Issue #5674 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

Ufunc override should normalize the sig keyword argument #5674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jaimefrio opened this issue Mar 12, 2015 · 1 comment · Fixed by #5677
Closed

Ufunc override should normalize the sig keyword argument #5674

jaimefrio opened this issue Mar 12, 2015 · 1 comment · Fixed by #5677

Comments

@jaimefrio
Copy link
Member

Opening this as a reminder of unfinished work after merging #5659.

The ufunc override mechanism should make sure that, if sig is part of the keyword arguments, it gets normalized to signature.

It may also be a good idea to make signature the keyword argument announced in the docs, with a small footnote saying that sig is also acceptable for backwards compatibility reasons, rather than having them advertised as equally valid alternatives.
@njsmith
Copy link
Member
njsmith commented Mar 12, 2015

CC @cowlicks
On Mar 12, 2015 2:42 PM, "Jaime" notifications@github.com wrote:

Opening this as a reminder of unfinished work after merging #5659
#5659.

The ufunc override mechanism should make sure that, if sig is part of the
keyword arguments, it gets normalized to signature.

It may also be a good idea to make signature the keyword argument
announced in the docs, with a small footnote saying that sig is also
acceptable for backwards compatibility reasons, rather than having them
advertised as equally valid alternatives.

—
Reply to this email directly or view it on GitHub
#5674.

jaimefrio added a commit to jaimefrio/numpy that referenced this issue Mar 13, 2015
@jaimefrio
ENH: normalize 'sig' to 'signature' in ufunc override
533f616 
Closes numpy#5674
@jaimefrio jaimefrio mentioned this issue Mar 13, 2015
Merged
@cowlicks cowlicks mentioned this issue Mar 14, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Override sig normalize jaimefrio/numpy
2 participants
@njsmith @jaimefrio
0