8000 BUG: f2py does not generate wrappers for modules when compiling multiple files (regression) · Issue #25337 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: f2py does not generate wrappers for modules when compiling multiple files (regression) #25337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andrea-bia opened this issue Dec 7, 2023 · 1 comment · Fixed by #25361
Closed

BUG: f2py does not generate wrappers for modules when compiling multiple files (regression) #25337

andrea-bia opened this issue Dec 7, 2023 · 1 comment · Fixed by #25361
Labels
00 - Bug 06 - Regression component: numpy.f2py

Comments

@andrea-bia
Copy link
Contributor

Describe the issue:

In the latest version (2.0.0.dev0+git20231201.44570a8) of the codebase, I have observed a regression regarding the access to module variables when compiling more fortran files.
Specifically, after compiling two Fortran files:
data.F90

module data
   real(8) :: shift
contains
   subroutine set_shift(in_shift)
      real(8), intent(in) :: in_shift
      shift = in_shift
   end subroutine set_shift
end module data

and use_data.F90

subroutine shift_a(dim_a, a)
    use data, only: shift
    integer, intent(in) :: dim_a
    real(8), intent(inout), dimension(dim_a) :: a
    a = a + shift
end subroutine shift_a

with the command:

f2py -m example -c use_data.F90 data.F90

we cannot access example.data:

>>> import example
>>> example.data
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: module 'example' has no attribute 'data'
2.0.0.dev0+git20231201.44570a8 
Build Dependencies:
  blas:
    detection method: pkgconfig
    found: true
    include directory: /opt/intel//oneapi/mkl/latest/lib/pkgconfig/../../include
    lib directory: /opt/intel//oneapi/mkl/latest/lib/pkgconfig/../../lib/intel64
    name: mkl-dynamic-lp64-seq
    openblas configuration: unknown
    pc file directory: /usr/local/share/pkgconfig
    version: '2023.1'
  lapack:
    detection method: internal
    found: true
    include directory: unknown
    lib directory: unknown
    name: dep140360165707840
    openblas configuration: unknown
    pc file directory: unknown
    version: 2.0.0.dev0+git20231201.44570a8
Compilers:
  c:
    commands: cc
    linker: ld.bfd
    name: gcc
    version: 13.2.1
  c++:
    commands: c++
    linker: ld.bfd
    name: gcc
    version: 13.2.1
  cython:
    commands: cython
    linker: cython
    name: cython
    version: 3.0.6
Machine Information:
  build:
    cpu: x86_64
    endian: little
    family: x86_64
    system: linux
  host:
    cpu: x86_64
    endian: little
    family: x86_64
    system: linux
Python Information:
  path: /usr/bin/python3
  version: '3.12'
SIMD Extensions:
  baseline:
  - SSE
  - SSE2
  - SSE3
  found:
  - SSSE3
  - SSE41
  - POPCNT
  - SSE42
  - AVX
  - F16C
  - FMA3
  - AVX2
  not found:
  - AVX512F
  - AVX512CD
  - AVX512_KNL
  - AVX512_KNM
  - AVX512_SKX
  - AVX512_CLX
  - AVX512_CNL
  - AVX512_ICL
  - AVX512_SPR

But we can in version 1.26.2:

>>> import example        
>>> example.data  
<fortran object>
1.26.2 
Build Dependencies:
  blas:
    detection method: pkgconfig
    found: true
    include directory: /usr/local/include
    lib directory: /usr/local/lib
    name: openblas64
    openblas configuration: USE_64BITINT=1 DYNAMIC_ARCH=1 DYNAMIC_OLDER= NO_CBLAS=
      NO_LAPACK= NO_LAPACKE= NO_AFFINITY=1 USE_OPENMP= HASWELL MAX_THREADS=2
    pc file directory: /usr/local/lib/pkgconfig
    version: 0.3.23.dev
  lapack:
    detection method: internal
    found: true
    include directory: unknown
    lib directory: unknown
    name: dep140640983012528
    openblas configuration: unknown
    pc file directory: unknown
    version: 1.26.2
Compilers:
  c:
    commands: cc
    linker: ld.bfd
    name: gcc
    version: 10.2.1
  c++:
    commands: c++
    linker: ld.bfd
    name: gcc
    version: 10.2.1
  cython:
    commands: cython
    linker: cython
    name: cython
    version: 3.0.5
Machine Information:
  build:
    cpu: x86_64
    endian: little
    family: x86_64
    system: linux
  host:
    cpu: x86_64
    endian: little
    family: x86_64
    system: linux
Python Information:
  path: /opt/python/cp310-cp310/bin/python
  version: '3.10'
SIMD Extensions:
  baseline:
  - SSE
  - SSE2
  - SSE3
  found:
  - SSSE3
  - SSE41
  - POPCNT
  - SSE42
  - AVX
  - F16C
  - FMA3
  - AVX2
  not found:
  - AVX512F
  - AVX512CD
  - AVX512_KNL
  - AVX512_KNM
  - AVX512_SKX
  - AVX512_CLX
  - AVX512_CNL
  - AVX512_IC

This appears related to this added to fix this bug regarding common blocks.
I don't think the observed behavior is intentional in general but please let me know if I am missing something.

Reproduce the code example:

data = '''
module data
   real(8) :: shift
contains
   subroutine set_shift(in_shift)
      real(8), intent(in) :: in_shift
      shift = in_shift
   end subroutine set_shift
end module data
'''

use_data = '''
subroutine shift_a(dim_a, a)
    use data, only: shift
    integer, intent(in) :: dim_a
    real(8), intent(inout), dimension(dim_a) :: a
    a = a + shift
end subroutine shift_a
'''

with open('data.F90', 'w') as f:
    f.write(data)

with open('use_data.F90', 'w') as f:
    f.write(use_data)

import subprocess

subprocess.call(['f2py', '-c', '-m', 'example', 'use_data.F90', 'data.F90'])

import importlib

example = importlib.import_module('example')

example.data.set_shift(1.0)

import numpy as np

a = np.array([1.0, 2.0, 3.0], dtype=np.float64)

print(a)

example.shift_a(a)

print(a)

Error message:

No response

Python and NumPy Versions:

2.0.0.dev0+git20231201.44570a8
3.12.0 (main, Oct 2 2023, 00:00:00) [GCC 13.2.1 20230918 (Red Hat 13.2.1-3)]

Runtime Environment:

No response

Context for the issue:

No response
@HaoZeke
Copy link
Member
HaoZeke commented Dec 8, 2023 •
edited
Loading

Thanks for the report @andrea-bia, will take a look this weekend. It is indeed a bug, and the older behavior was correct.

HaoZeke added a commit to HaoZeke/numpy that referenced this issue Dec 10, 2023
@HaoZeke @andrea-bia
TST: Add one for numpygh-25337
da678f6 
Co-authored-by: andrea-bia <andrea-bia@users.noreply.github.com>
HaoZeke added a commit to HaoZeke/numpy that referenced this issue Dec 10, 2023
@HaoZeke
BUG: Fix numpygh-25337 [f2py]
0cbdf62
@HaoZeke HaoZeke mentioned this issue Dec 10, 2023
Merged
charris pushed a commit to charris/numpy that referenced this issue Dec 22, 2023
@HaoZeke @andrea-bia @charris
TST: Add one for numpygh-25337
9d27974 
Co-authored-by: andrea-bia <andrea-bia@users.noreply.github.com>
charris pushed a commit to charris/numpy that referenced this issue Dec 22, 2023
@HaoZeke @charris
BUG: Fix numpygh-25337 [f2py]
657263a
@charris charris mentioned this issue Dec 22, 2023
Merged
@mancellin mancellin mentioned this issue Feb 22, 2024
Closed
HaoZeke added a commit to HaoZeke/numpy that referenced this issue Nov 4, 2024
@HaoZeke
BUG: Handle multi-module files and common better
531a694 
Fixes numpygh-25186 numpygh-25337 numpygh-27622
@HaoZeke HaoZeke mentioned this issue Nov 4, 2024
Merged
charris pushed a commit to charris/numpy that referenced this issue Nov 17, 2024
@HaoZeke @charris
BUG: Handle multi-module files and common better
690e663 
Fixes numpygh-25186 numpygh-25337 numpygh-27622
@charris charris mentioned this issue Nov 17, 2024
Merged
@TimotheusBachinger TimotheusBachinger mentioned this issue Nov 25, 2024
Closed
ArvidJB pushed a commit to ArvidJB/numpy that referenced this issue Jan 8, 2025
@HaoZeke @ArvidJB
BUG: Handle multi-module files and common better
a012752 
Fixes numpygh-25186 numpygh-25337 numpygh-27622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
00 - Bug 06 - Regression component: numpy.f2py
Projects
None yet
Milestone
No milestone
3 participants
@charris @HaoZeke @andrea-bia
0