8000 BUG: pypy39 wheel builder failing · Issue #25334 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: pypy39 wheel builder failing #25334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ngoldbaum opened this issue Dec 6, 2023 · 3 comments · Fixed by #25444
Closed

BUG: pypy39 wheel builder failing #25334

ngoldbaum opened this issue Dec 6, 2023 · 3 comments · Fixed by #25444
Milestone
2.0.0 release

Comments

@ngoldbaum
Copy link
Member

The wheel builder workflow has been failing for pypy3.9 since last week, see here.

The errors look like:

________________ TestNewBufferProtocol.test_error_too_many_dims ________________
  [gw1] linux -- Python 3.9.17 /tmp/tmp.0jQGXevz9m/venv/bin/python
  
  self = <numpy._core.tests.test_multiarray.TestNewBufferProtocol object at 0x0000000006a06368>
  
      @pytest.mark.slow
      def test_error_too_many_dims(self):
          def make_ctype(shape, scalar_type):
              t = scalar_type
              for dim in shape[::-1]:
                  t = dim * t
              return t
      
          # Try constructing a memory with too many dimensions:
          c_u8_65d = make_ctype((1,)*65, ctypes.c_uint8)
          try:
              m = memoryview(c_u8_65d())
          except ValueError:
              pytest.skip("memoryview doesn't support more dimensions")
      
          assert_equal(m.ndim, 65)
      
          with pytest.raises(RuntimeError, match=".*ndim"):
  >           np.array(m)
  E           Failed: DID NOT RAISE <class 'RuntimeError'>

And I think that was due to #25149.
@ngoldbaum ngoldbaum changed the title BUG: pypy39 wheel builder intermittently failing BUG: pypy39 wheel builder failing Dec 6, 2023
@neutrinoceros neutrinoceros mentioned this issue Dec 6, 2023
Closed
@seberg
Copy link
Member
seberg commented Dec 6, 2023

Matti already fixed this in pypy, although we should probably skip it until a future version of PyPy comes out (or TBH, just delete the test, it never does what it was designed for anyway).

@charris
Copy link
Member
charris commented Dec 6, 2023 •
edited
Loading

I keep cibuildwheel pinned at v2.16.0 to avoid that and have a PR removing the pin for when PyPy-7.3.14 comes out. I believe v2.16.1 also works, v2.16.2 fails.

@seberg seberg added this to the 2.0.0 release milestone Dec 19, 2023
rgommers added a commit to rgommers/numpy that referenced this issue Dec 21, 2023
@rgommers
TST: remove TestNewBufferProtocol.test_error_too_many_dims
5a93cfe 
This is failing in the tests for PyPy 3.9 wheel builds, which
is blocking the production of nightlies. The test doesn't really do what
it was designed for and is slow, so delete it - as suggested on
numpygh-25334.

Closes numpygh-25334

[skip ci]
@rgommers rgommers mentioned this issue Dec 21, 2023
Merged
@mattip
Copy link
Member
mattip commented Dec 25, 2023

I keep cibuildwheel pinned at v2.16.0 to avoid that and have a PR removing the pin for when PyPy-7.3.14 comes out.

@charris PyPy-7.3.14 was released, so hopefully that pin can be updated to 2.16.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0 release
Development

Successfully merging a pull request may close this issue.

TST: remove TestNewBufferProtocol.test_error_too_many_dims rgommers/numpy
4 participants
@seberg @charris @mattip @ngoldbaum
0