10000 Typing: Unexpected keyword argument `kind` for `isin` · Issue #24491 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

Typing: Unexpected keyword argument kind for isin #24491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bersbersbers opened this issue Aug 22, 2023 · 0 comments · Fixed by #24527
Closed

Typing: Unexpected keyword argument kind for isin #24491

bersbersbers opened this issue Aug 22, 2023 · 0 comments · Fixed by #24527
Labels
00 - Bug

Comments

@bersbersbers
Copy link
Contributor

Describe the issue:

The implementation of isin has a kind argument

numpy/numpy/lib/arraysetops.py

Lines 767 to 768 in cc91b10

def isin(element, test_elements, assume_unique=False, invert=False, *,
kind=None):

that is missing in the type hints:

numpy/numpy/lib/arraysetops.pyi

Lines 331 to 336 in cc91b10

def isin(
element: ArrayLike,
test_elements: ArrayLike,
assume_unique: bool = ...,
invert: bool = ...,
) -> NDArray[bool_]: ...

Reproduce the code example:

import numpy as np

np.isin([1, 2, 3], [1], kind="table")

Error message:

# mypy bug.py
bug.py:3: error: Unexpected keyword argument "kind" for "isin"  [call-arg]
bug.py:3: note: See https://mypy.rtfd.io/en/stable/_refs.html#code-call-arg for more info
Found 1 error in 1 file (checked 1 source file)

Runtime information:

numpy 1.25.2
mypy 1.5.1 (compiled: yes)
Python 3.11.4 (tags/v3.11.4:d2340ef, Jun 7 2023, 05:45:37) [MSC v.1934 64 bit (AMD64)]

Context for the issue:

No response
jakevdp added a commit to jakevdp/numpy that referenced this issue Aug 24, 2023
@jakevdp
Typing: add kind argument to numpy.isin
050382b 
Fixes numpy#24491
jakevdp added a commit to jakevdp/numpy that referenced this issue Aug 24, 2023
@jakevdp
TYP: add kind argument to numpy.isin type specification
d75fcfe 
Fixes numpy#24491
@jakevdp jakevdp mentioned this issue Aug 24, 2023
Merged
rgommers pushed a commit that referenced this issue Aug 25, 2023
@jakevdp
TYP: add kind argument to numpy.isin type specification (#24527)
c790693 
Fixes #24491

[skip ci]
charris pushed a commit to charris/numpy that referenced this issue Aug 25, 2023
@jakevdp @charris
TYP: add kind argument to numpy.isin type specification (numpy#24527)
603311d 
Fixes numpy#24491

[skip ci]
@charris charris mentioned this issue Aug 25, 2023
Merged
charris pushed a commit to charris/numpy that referenced this issue Nov 11, 2023
@jakevdp @charris
TYP: add kind argument to numpy.isin type specification (numpy#24527)
a2725d9 
Fixes numpy#24491

[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
00 - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TYP: add kind argument to numpy.isin type specification jakevdp/numpy
1 participant
@bersbersbers
2AC0
0