8000 histogradd dispatcher does not dispatch correctly on bins · Issue #13728 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

histogradd dispatcher does not dispatch correctly on bins #13728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mhvk opened this issue Jun 6, 2019 · 5 comments · Fixed by #13757
Closed

histogradd dispatcher does not dispatch correctly on bins #13728

mhvk opened this issue Jun 6, 2019 · 5 comments · Fixed by #13757
Labels
00 - Bug component: numpy.lib

Comments

@mhvk
Copy link
Contributor
mhvk commented Jun 6, 2019 •
edited
Loading

As a reminder for myself if nobody else gets around to it: bins in histogramdd is a sequence of arrays, not an array itself, so one should dispatch on things inside it (if iterable).

EDIT: samples may also be interpreted wrong, since it can be a sequence of arrays.
@mhvk
Copy link
Contributor Author
mhvk commented Jun 6, 2019

And histogram2d also does not dispatch correctly on bins

@abhinavsagar
Copy link
Contributor

Should we document this ?

@mhvk
Copy link
Contributor Author
mhvk commented Jun 7, 2019

@abhinavsagar - we should fix it! Ideally before 1.17 comes out...

@mhvk
Copy link
Contributor Author
mhvk commented Jun 7, 2019

I'll cc @shoyer just in case he has time before me.

@seberg seberg added this to the 1.17.0 release milestone Jun 7, 2019
@mhvk mhvk mentioned this issue Jun 12, 2019
Closed
33 tasks
shoyer added a commit to shoyer/numpy that referenced this issue Jun 12, 2019
@shoyer
MAINT: fix histogram*d dispatchers
080bf00 
fixes numpyGH-13728
@shoyer shoyer mentioned this issue Jun 12, 2019
Merged
@shoyer
Copy link
Member
shoyer commented Jun 12, 2019

OK, these are pretty messy functions! See #13757 for a PR.

charris pushed a commit to charris/numpy that referenced this issue Jul 17, 2019
@shoyer @charris
MAINT: fix histogram*d dispatchers
7030fd1 
fixes numpyGH-13728
@charris charris mentioned this issue Jul 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
00 - Bug component: numpy.lib
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MAINT: fix histogram*d dispatchers shoyer/numpy
4 participants
@seberg @shoyer @mh 2C68 vk @abhinavsagar
0