8000 BUG: np.broadcast(1, **{}) raises ValueError: keyword arguments not accepted. · Issue #13455 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

BUG: np.broadcast(1, **{}) raises ValueError: keyword arguments not accepted. #13455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brilee opened this issue May 2, 2019 · 3 comments · Fixed by #13508
Closed

BUG: np.broadcast(1, **{}) raises ValueError: keyword arguments not accepted. #13455

brilee opened this issue May 2, 2019 · 3 comments · Fixed by #13508
Labels
00 - Bug component: numpy._core

Comments

@brilee
Copy link
brilee commented May 2, 2019

numpy/numpy/core/src/multiarray/iterators.c

Line 1391 in 4b6b29a

if (kwds != NULL) {
shouldn't be directly comparing to NULL; it should be checking that the kwargs dictionary is len 0 or something like that.
@mattip mattip changed the title np.broadcast(1, **{}) raises ValueError: keyword arguments not accepted. BUG: np.broadcast(1, **{}) raises ValueError: keyword arguments not accepted. May 2, 2019
@seberg
Copy link
Member
seberg commented May 2, 2019

Seems like a simply enough fix. May want to wait for gh-13445 to avoid the possible merge conflict.

@mattip
Copy link
Member
mattip commented May 2, 2019 •
edited
Loading

grep 'kw* != NULL' shows 7 occurrences in the source

Edit: but all the others are followed by code that does something. This is the only one that needs fixing

@hdamron17
Copy link
Contributor

Hello, I have fixed this issue, but I am not entirely sure where in the test script to add tests for this since I am having a difficulty matching up the C code with the python.

Also, since gh-13445 has been merged, I assume this issue is ready to be fixed.

@hdamron17 hdamron17 mentioned this issue May 8, 2019
Merged
hdamron17 added a commit to hdamron17/numpy that referenced this issue May 8, 2019
@hdamron17
BUG: Removes ValueError for empty kwargs in arraymultiter_new
c9407cc 
closes numpygh-13455
charris pushed a commit to charris/numpy that referenced this issue May 14, 2019
@hdamron17 @charris
BUG: Removes ValueError for empty kwargs in arraymultiter_new
1bd5d34 
closes numpygh-13455
@charris charris mentioned this issue May 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
00 - Bug component: numpy._core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BUG: Removes ValueError for empty kwargs in arraymultiter_new hdamron17/numpy
4 participants
@seberg @mattip @brilee @hdamron17
0