8000 audit: support for --json output by finnp · Pull Request #20568 · npm/npm · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

Conversation

finnp
Copy link
Contributor
@finnp finnp commented May 10, 2018

Makes use of the json formatter of npm-audit-report when using the --json option.

resolves #20587

@finnp finnp requested a review from a team as a code owner May 10, 2018 00:28
@naugtur
Copy link
naugtur commented May 10, 2018

the failing check is on node6, npm audit with details reporter fails on node6 because it uses Object.entries

@zkat
Copy link
Contributor
zkat commented May 10, 2018

just rebase onto latest. It's already been fixed.

@finnp finnp changed the base branch from latest to release-next May 10, 2018 18:00
@finnp
Copy link
Contributor Author
finnp commented May 10, 2018

I was up-to-date with latest. But I rebased onto release-next. That's the right branch, right?

@zkat
Copy link
Contributor
zkat commented May 10, 2018

that should be fine. And it looks like you're green now, so 👍

Copy link
Contributor
@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0