8000 Fix `npm version` command when `package-lock.json` is gitignored by nwoltman · Pull Request #20154 · npm/npm · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

Fix npm version command when package-lock.json is gitignored #20154

Closed
wants to merge 1 commit into from
Closed

Fix npm version command when package-lock.json is gitignored #20154

wants to merge 1 commit into from

Conversation

nwoltman
Copy link
Contributor

Fixes #17168

Fixes this error:

> npm version minor -m "v%s"
v0.1.0
npm ERR! code 1
npm ERR! Command failed: git -c core.longpaths=true add C:\GitHub\compile-mime-match\package-lock.json
npm ERR! The following paths are ignored by one of your .gitignore files:
npm ERR! package-lock.json
npm ERR! Use -f if you really want to add them.
npm ERR!

This was originally fixed by #17505 but the fix was accidentally undone in #17742.

@nwoltman nwoltman requested a review from a team as a code owner March 24, 2018 06:06
iarna pushed a commit that referenced this pull request Apr 9, 2018
@nwoltman @iarna
Fix npm version command when package-lock.json is gitignored
c3da6e4 
Credit: @nwoltman
PR-URL: #20154
Reviewed-By: @iarna
Fixes: #17168
iarna pushed a commit that referenced this pull request Apr 10, 2018
@nwoltman @iarna
version: Let version succeed when package-lock.json is gitignored
50d8391 
Credit: @nwoltman
PR-URL: #20154
Reviewed-By: @iarna
Fixes: #17168
iarna pushed a commit that referenced this pull request Apr 10, 2018
@nwoltman @iarna
version: Let version succeed when package-lock.json is gitignored
2014ca5 
Credit: @nwoltman
PR-URL: #20154
Reviewed-By: @iarna
Fixes: #17168
iarna pushed a commit that referenced this pull request Apr 10, 2018
@nwoltman @iarna
version: Let version succeed when package-lock.json is gitignored
3625805 
Credit: @nwoltman
PR-URL: #20154
Reviewed-By: @iarna
Fixes: #17168
iarna pushed a commit that referenced this pull request Apr 11, 2018
@nwoltman @iarna
version: Let version succeed when package-lock.json is gitignored
f9de7ef 
Credit: @nwoltman
PR-URL: #20154
Reviewed-By: @iarna
Fixes: #17168
iarna pushed a commit that referenced this pull request Apr 11, 2018
@nwoltman @iarna
version: Let version succeed when package-lock.json is gitignored
339416f 
Credit: @nwoltman
PR-URL: #20154
Reviewed-By: @iarna
Fixes: #17168
iarna pushed a commit that referenced this pull request Apr 11, 2018
@nwoltman @iarna
version: Let version succeed when package-lock.json is gitignored
f18be9b 
Credit: @nwoltman
PR-URL: #20154
Reviewed-By: @iarna
Fixes: #17168
@iarna
Copy link
Contributor
iarna commented May 3, 2018

Thank you for this! It shipped in 6.0.0! =)

@iarna iarna closed this May 3, 2018
@nwoltman nwoltman deleted the fix-npm-version branch May 4, 2018 02:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@iarna iarna iarna approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

npm version fails if package-lock.json is gitignored

2 participants

@nwoltman @iarna
0