10000 chore: upgrade tap@21 by reggi · Pull Request #8085 · npm/cli · GitHub
[go: up one dir, main page]
Skip to content

chore: upgrade tap@21 #8085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 22 commits into
base: latest
Choose a base branch
from
+11,074 −10,514
Draft

chore: upgrade tap@21 #8085

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
133cdf9
tap upgrade to 21
reggi Feb 4, 2025
2d11c4e
mock -> mockRequire
reggi Feb 4, 2025
392ddea
template-oss-apply
reggi Feb 4, 2025
e2c0b7f
deps: template-oss
reggi Feb 4, 2025
a05b0b8
update tap for every workspace to avoid collisions
reggi Feb 5, 2025
0bd68c4
template oss everything
reggi Feb 5, 2025
61070a9
patch latest issue
reggi Feb 5, 2025
e9e6d58
allow map files in node modules
reggi Feb 6, 2025
6bc4195
update node_modules ignore
reggi Feb 6, 2025
53215c7
new included map files
reggi Feb 6, 2025
45b44cf
fix exit handler test
reggi Feb 6, 2025
e30ad0b
updates snapshots
reggi Feb 7, 2025
140ac57
fixes update-notifier
reggi Feb 7, 2025
d9f6b3e
fix diff
reggi Feb 11, 2025
106668d
doctor tests, more deep mocking issues
reggi Feb 12, 2025
9e8f869
exec
reggi Feb 12, 2025
3793990
explore
reggi Feb 12, 2025
5bb465a
revert npm to get link to pass
reggi Feb 13, 2025
702698d
fixes ls
reggi Feb 13, 2025
d0b3151
fix run-script
reggi Feb 13, 2025
f0ba3ce
fix log
reggi Feb 14, 2025
2bc41d4
re-geneerate snapshots
reggi Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix run-script
  • Loading branch information
@reggi
reggi committed Feb 13, 2025
commit d0b31515286e855b437fd4e0ea1ad45252979eef
20 changes: 10 additions & 10 deletions tap-snapshots/test/lib/commands/run-script.js.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ exports[`test/lib/commands/run-script.js > TAP > workspaces > failed workspace r
Lifecycle script \`glorp\` failed with error:
code ERR
workspace a@1.0.0
location {CWD}/.tap/fixtures/test-lib-commands-run-script.js-workspaces-failed-workspace-run-with-succeeded-runs/prefix/packages/a
location {CWD}/prefix/packages/a
ERR
`

Expand Down Expand Up @@ -207,42 +207,42 @@ Scripts available in a@1.0.0 via \`npm run-script\`:
exports[`test/lib/commands/run-script.js > TAP > workspaces > missing scripts in all workspaces > should log error msgs for each workspace script 1`] = `
Lifecycle script \`missing-script\` failed with error:
workspace a@1.0.0
location {CWD}/.tap/fixtures/test-lib-commands-run-script.js-workspaces-missing-scripts-in-all-workspaces/prefix/packages/a
location {CWD}/prefix/packages/a
Missing script: "missing-script"
npm error
To see a list of scripts, run:
npm run --workspace=a@1.0.0
Lifecycle script \`missing-script\` failed with error:
workspace b@2.0.0
location {CWD}/.tap/fixtures/test-lib-commands-run-script.js-workspaces-missing-scripts-in-all-workspaces/prefix/packages/b
location {CWD}/prefix/packages/b
Missing script: "missing-script"
npm error
To see a list of scripts, run:
npm run --workspace=b@2.0.0
Lifecycle script \`missing-script\` failed with error:
workspace c@1.0.0
location {CWD}/.tap/fixtures/test-lib-commands-run-script.js-workspaces-missing-scripts-in-all-workspaces/prefix/packages/c
location {CWD}/prefix/packages/c
Missing script: "missing-script"
npm error
To see a list of scripts, run:
npm run --workspace=c@1.0.0
Lifecycle script \`missing-script\` failed with error:
workspace d@1.0.0
location {CWD}/.tap/fixtures/test-lib-commands-run-script.js-workspaces-missing-scripts-in-all-workspaces/prefix/packages/d
location {CWD}/prefix/packages/d
Missing script: "missing-script"
npm error
To see a list of scripts, run:
npm run --workspace=d@1.0.0
Lifecycle script \`missing-script\` failed with error:
workspace e
location {CWD}/.tap/fixtures/test-lib-commands-run-script.js-workspaces-missing-scripts-in-all-workspaces/prefix/packages/e
location {CWD}/prefix/packages/e
Missing script: "missing-script"
npm error
To see a list of scripts, run:
npm run --workspace=e
Lifecycle script \`missing-script\` failed with error:
workspace noscripts@1.0.0
location {CWD}/.tap/fixtures/test-lib-commands-run-script.js-workspaces-missing-scripts-in-all-workspaces/prefix/packages/noscripts
location {CWD}/prefix/packages/noscripts
Missing script: "missing-script"
npm error
To see a list of scripts, run:
Expand All @@ -252,14 +252,14 @@ To see a list of scripts, run:
exports[`test/lib/commands/run-script.js > TAP > workspaces > missing scripts in some workspaces > should log error msgs for each workspace script 1`] = `
Lifecycle script \`test\` failed with error:
workspace a@1.0.0
location {CWD}/.tap/fixtures/test-lib-commands-run-script.js-workspaces-missing-scripts-in-some-workspaces/prefix/packages/a
location {CWD}/prefix/packages/a
Missing script: "test"
npm error
To see a list of scripts, run:
npm run --workspace=a@1.0.0
Lifecycle script \`test\` failed with error:
workspace b@2.0.0
location {CWD}/.tap/fixtures/test-lib-commands-run-script.js-workspaces-missing-scripts-in-some-workspaces/prefix/packages/b
location {CWD}/prefix/packages/b
Missing script: "test"
npm error
To see a list of scripts, run:
Expand All @@ -269,6 +269,6 @@ To see a list of scripts, run:
exports[`test/lib/commands/run-script.js > TAP > workspaces > single failed workspace run > should log error msgs for each workspace script 1`] = `
Lifecycle script \`test\` failed with error:
workspace c@1.0.0
location {CWD}/.tap/fixtures/test-lib-commands-run-script.js-workspaces-single-failed-workspace-run/prefix/packages/c
location {CWD}/prefix/packages/c
err
`
6 changes: 4 additions & 2 deletions test/lib/commands/run-script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,20 +334,22 @@ t.test('skip pre/post hooks when using ignoreScripts', async t => {
t.same(RUN_SCRIPTS(), [
{
path: npm.localPrefix,
args: [],
scriptShell: undefined,
stdio: 'inherit',
pkg: {
name: 'x',
version: '1.2.3',
_id: 'x@1.2.3',
scripts: {
preenv: 'echo before the env',
postenv: 'echo after the env',
env: 'env',
},
_id: 'x@1.2.3',
[Symbol.for('newline')]: '',
[Symbol.for('indent')]: '',
},
event: 'env',
args: [],
},
])
})
Expand Down
0