8000 unsupported: npm v6.10.0 breaks on node v6.0, v6.1, v9.0 - v9.2 by ljharb · Pull Request #279 · npm/cli · GitHub
[go: up one dir, main page]
Skip to content

unsupported: npm v6.10.0 breaks on node v6.0, v6.1, v9.0 - v9.2 #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

unsupported: npm v6.10.0 breaks on node v6.0, v6.1, v9.0 - v9.2 #279

wants to merge 1 commit into from

Conversation

ljharb
Copy link
Contributor
@ljharb ljharb commented Nov 3, 2019

nvm-sh/nvm@100861d

npm v6.10 caused npm to no longer work on node v6.0, v6.1, v9.0, v9.1, and v9.2.

This PR isn't to debate semver adherence, though, I just want to update the "unsupported" logic to be correct :-)

I'd also like to update the supportedNode list, but it'd need a "max" to be supported, or instead of "min" a semver range, and that seemed like a bigger change.

@ljharb ljharb requested a review from a team as a code owner November 3, 2019 18:02
@ljharb
Copy link
Contributor Author
ljharb commented Nov 3, 2019

The failing test is in "test/tap/all-package-metadata.js" on node 12 in a rimraf call; i wonder if it's flaky and needs to be rerun?

@ljharb ljharb mentioned this pull request Nov 5, 2019
Merged
@darcyclarke darcyclarke added release semver:minor new backwards-compatible feature labels Nov 5, 2019
@darcyclarke darcyclarke mentioned this pull request Nov 5, 2019
Closed
3 tasks
@ruyadorno ruyadorno mentioned this pull request Nov 5, 2019
C 8000 losed
@ruyadorno ruyadorno closed this in cd14d47 Nov 5, 2019
@ljharb ljharb deleted the patch-1 branch November 5, 2019 21:34
This was referenced Nov 14, 2019
Open
Open
This was referenced Nov 25, 2019
Open
Open
Merged
This was referenced Dec 5, 2019
Open
Open
This was referenced Dec 18, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
This was referenced Jan 17, 2020
Open
Open
This was referenced Feb 25, 2020
Open
Open
This was referenced Mar 14, 2020
Merged
Open
Open
Open
This was referenced Mar 20, 2020
Open
Open
@snyk-bot snyk-bot mentioned this pull request Dec 10, 2020
Open
@f4lco0n f4lco0n mentioned this pull request Mar 23, 2023
Open
@snyk-bot snyk-bot mentioned this pull request May 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ruyadorno ruyadorno ruyadorno approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

semver:minor new backwards-compatible feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ljharb @ruyadorno @darcyclarke
0