8000 Fix regression in lockfile repair for sub-dependencies by feelepxyz · Pull Request #265 · npm/cli · GitHub
[go: up one dir, main page]
Skip to content

Fix regression in lockfile repair for sub-dependencies #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix regression in lockfile repair for sub-dependencies #265

wants to merge 1 commit into from
+122 −3

Conversation

feelepxyz
Copy link
Contributor

This fixes a regression where lockfiles with missing sub-dependencies
are no longer repaired. The regression was introduced in this commit:
1fafb51 which in turn was bringing back
the change from this commit 24acc9f.

Changing loaded has caused a lot of churn so not sure if this will cause further regressions, but looks like each regression was tested.

I also couldn't get the mock registry to work as the test would just hang indefinitely when trying to initialise it with mr({ port: common.port }, function (er, s) {.... Would love any help refactoring the current tests to use the mock registry/how to set it up locally.

@feelepxyz
Fix regression in lockfile repair for sub-deps
f351e00 
This fixes a regression where lockfiles with missing sub-dependencies
are no longer repaired. The regression was introduced in this commit:
1fafb51 which in turn was bringing back
the change from this commit 24acc9f.
@feelepxyz feelepxyz requested a review from a team as a code owner October 9, 2019 11:57
@feelepxyz feelepxyz mentioned this pull request Oct 9, 2019
Closed
@feelepxyz feelepxyz changed the title Fix regression in lockfile repair for sub-deps Fix regression in lockfile repair for sub-dependencies Oct 9, 2019
@mikemimik mikemimik mentioned this pull request Oct 29, 2019
Closed
@mikemimik mikemimik closed this in b6588a8 Oct 29, 2019
@feelepxyz
Copy link
Contributor Author

@mikemimik thanks for the merge & release! 🙇

@feelepxyz feelepxyz deleted the feelepxyz/fix-inflate-shrinkwrap-bug branch October 29, 2019 18:51
@mikemimik mikemimik self-assigned this Oct 29, 2019
@mikemimik mikemimik added the semver:patch semver patch level for changes label Oct 29, 2019
This was referenced Nov 7, 2019
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Nov 14, 2019
Open
This was referenced Nov 25, 2019
Open
Open
This was referenced Dec 5, 2019
Open
Open
This was referenced Dec 18, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Jan 7, 2020
Open
This was referenced Jan 17, 2020
Open
Open
This was referenced Feb 25, 2020
Open
Open
This was referenced Mar 14, 2020
Merged
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 8, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Dec 10, 2020
Open
@snyk-bot snyk-bot mentioned this pull request May 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mikemimik mikemimik

Labels

semver:patch semver patch level for changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@feelepxyz @mikemimik
0