Support for disabling activity events#4430
Closed
Haydabase wants to merge 10 commits intonpgsql:mainfrom
Closed
Conversation
- nullability of options - documentation
Member
|
@Haydabase are you still interested in pursuing this further? As an alternative to this it seems like users might be able to (ab)use the sampling support on listeners to do this now. |
Member
|
Considering that I believe sampling should allow people to work around this I'll close this PR. Feel free to open another one if I missed something. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should address #4245, allowing disabling of the
received-first-responseevent, and introducing an"OnFirstResponse"enrich callback for consumers to implement their own recording (e.g. as a tag).Also allowed for disabling the
exceptionevent to mirror the option available on the Http instrumentation (here).Documentation PR: npgsql/doc#201
NOTE THIS BUILDS ON THE BRANCH FROM #4284, SO CURRENTLY INCLUDES THOSE CHANGES TOO (marked this as draft for now)