8000 #390: Add missing property in paginated response by kashifsoofi · Pull Request #393 · notion-dotnet/notion-sdk-net · GitHub
[go: up one dir, main page]
Skip to content

#390: Add missing property in paginated response #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 14, 2023
Merged

#390: Add missing property in paginated response #393

merged 3 commits into from
Oct 14, 2023
+3 −3

Conversation

kashifsoofi
Copy link
Contributor

Description

Add missing property in paginated response.

Fixes #390

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@KoditkarVedant
Copy link
Contributor

You might wanna remove the type property from Retrieve Comments Response.
image

@KoditkarVedant
Copy link
Contributor

It would have been easier to ask first if you could work on the issue to avoid duplicate work...

ksvaibhav
ksvaibhav reviewed Oct 13, 2023
View reviewed changes
Copy link
Collaborator
@ksvaibhav ksvaibhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment

@ksvaibhav ksvaibhav self-requested a review October 13, 2023 12:35
@kashifsoofi
Copy link
Contributor Author

It would have been easier to ask first if you could work on the issue to avoid duplicate work...

Apologies

@kashifsoofi
Copy link
Contributor Author

You might wanna remove the type property from Retrieve Comments Response. image

Done

@KoditkarVedant KoditkarVedant self-requested a review October 14, 2023 13:38
@KoditkarVedant KoditkarVedant merged commit b2d5708 into notion-dotnet:main Oct 14, 2023
@kashifsoofi kashifsoofi deleted the #390/add-missing-property-in-paginated-response branch October 15, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksvaibhav ksvaibhav Awaiting requested review from ksvaibhav

@KoditkarVedant KoditkarVedant Awaiting requested review from KoditkarVedant

Assignees
No one assigned
Labels
enhancement New feature or request feature hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing type property in Paginated response.
3 participants
@kashifsoofi @KoditkarVedant @ksvaibhav
0