8000 fix: could not deserialize unique_id by RandomUser14 · Pull Request #367 · notion-dotnet/notion-sdk-net · GitHub
[go: up one dir, main page]
Skip to content

fix: could not deserialize unique_id #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 16, 2023
Merged

fix: could not deserialize unique_id #367

merged 2 commits into from
Sep 16, 2023

Conversation

RandomUser14
Copy link
Contributor

Description

Added support for unique_id property type to fix deserialize issue.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@RandomUser14 RandomUser14 mentioned this pull request Jul 17, 2023
Closed
@KoditkarVedant
Copy link
Contributor

@RandomUser14 could you resolve the CodeFactor warnings.

@alfadormx
Copy link
alfadormx commented Aug 30, 2023 •
edited
Loading

Hello I am having issues with the unique_id as well and I see this PR could fix this issue
@RandomUser14 @KoditkarVedant , are you planning on merging this PR anytime soon? if not, which release version of Notion-dotnet shall I use ?
How come this PR has been since July?
Thanks for your kind help.

@KoditkarVedant
Copy link
Contributor
KoditkarVedant commented Sep 4, 2023 •
edited
Loading

@alfadormx I'll take a look this weekend and release the latest version. Could you please take a look at one failing check.

@lejafo
Copy link
lejafo commented Sep 15, 2023

Hi!
what's the status of this PR?

@KoditkarVedant KoditkarVedant merged commit dd5a5ad into notion-dotnet:main Sep 16, 2023
@KoditkarVedant KoditkarVedant linked an issue Sep 16, 2023 that may be closed by this pull request
Databases.QueryAsync() fails to deserialize database entries that have an ID property #366
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Databases.QueryAsync() fails to deserialize database entries that have an ID property
4 participants
@RandomUser14 @KoditkarVedant @alfadormx @lejafo
0