8000 Rename Text prop to String in Formula property filter 🚚 by KoditkarVedant · Pull Request #266 · notion-dotnet/notion-sdk-net · GitHub
[go: up one dir, main page]
Skip to content

Rename Text prop to String in Formula property filter 🚚 #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2022
Merged

Rename Text prop to String in Formula property filter 🚚 #266

merged 1 commit into from
Jul 10, 2022

Conversation

KoditkarVedant
Copy link
Contributor

Description

Renames Text prop to String in Formula property filter

Fixes # (issue)
#248

Type of change

Please delete options that are not relevant.

  • Breaking change (feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@KoditkarVedant KoditkarVedant linked an issue Jul 10, 2022 that may be closed by this pull request
formula property filters accept string instead of text. #248
Closed
@KoditkarVedant KoditkarVedant merged commit 9985c00 into notion-version-2022-02-22 Jul 10, 2022
@KoditkarVedant KoditkarVedant deleted the 248-formula-property-filter-accept-string-instead-of-text-arg branch July 10, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

formula property filters accept string instead of text.
1 participant
@KoditkarVedant
0