8000 232 - Matched the naming convention for property url across project by vijayvarmaD · Pull Request #238 · notion-dotnet/notion-sdk-net · GitHub
[go: up one dir, main page]
Skip to content

232 - Matched the naming convention for property url across project #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 3, 2022
Merged

232 - Matched the naming convention for property url across project #238

merged 3 commits into from
Jul 3, 2022

Conversation

vijayvarmaD
Copy link
Contributor
@vijayvarmaD vijayvarmaD commented Jun 25, 2022 •
edited
Loading

Description

Fixed the spelling and made the capitalization consistent across the project for the word "url".

It is being used in these formats:
1. "url" - JSON Property naming & variable naming
2.  "Url" - C# property & class naming
3.  "URL" - Constant field naming & Code Comments

Fixes # (issue)
#232

Type of change

#232 - Naming convention fix

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

#232 - Ran the unit tests as it was just the change in class & property names.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@vijayvarmaD vijayvarmaD changed the title 232 Matched the naming convention for property url across project 232 - Matched the naming convention for property url across project & 237 - Add ability to clear date property Jun 25, 2022
KoditkarVedant
KoditkarVedant requested changes Jun 26, 2022
View reviewed changes
Copy link
Contributor
@KoditkarVedant KoditkarVedant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vijayvarmaD I appreciate your contribution. One thing though - would you mind creating separate PR for each issue as they are not related?

@vijayvarmaD
Copy link
Contributor Author

Sure.

@vijayvarmaD vijayvarmaD changed the title 232 - Matched the naming convention for property url across project & 237 - Add ability to clear date property 232 - Matched the naming convention for property url across project Jun 27, 2022
@vijayvarmaD
Copy link
Contributor Author

@KoditkarVedant Separated the commits. Can you plz review the PR. Thanks

@KoditkarVedant KoditkarVedant merged commit 9ca4c5e into notion-dotnet:main Jul 3, 2022
@KoditkarVedant KoditkarVedant added this to the 2.2.4 milestone Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoditkarVedant KoditkarVedant KoditkarVedant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.4
Development

Successfully merging this pull request may close these issues.
2 participants
@vijayvarmaD @KoditkarVedant
0