8000 Add missing parent unit test for Create a page API :white_check_mark: by KoditkarVedant · Pull Request #102 · notion-dotnet/notion-sdk-net · GitHub
[go: up one dir, main page]
Skip to content

Add missing parent unit test for Create a page API ✅ #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2021
Merged

Add missing parent unit test for Create a page API ✅ #102

merged 1 commit into from
Aug 18, 2021

Conversation

KoditkarVedant
Copy link
Contributor

Description

  • IPagesClient.CreateAsync now throws Argument Null Exception if Parent and Properties are missing.
  • Add missing parent unit test for create a page API.

Fixes # (issue)
#69

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@KoditkarVedant KoditkarVedant linked an issue Aug 18, 2021 that may be closed by this pull request
Page create test case missing Parent. #69
Closed
@KoditkarVedant KoditkarVedant merged commit f48fa7b into main Aug 18, 2021
@KoditkarVedant KoditkarVedant deleted the tests/69-add-test-to-check-missing-parent branch September 9, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page create test case missing Parent.
1 participant
@KoditkarVedant
0