8000 Bumping version from 5.19.0 to 5.20.0 by liranmauda · Pull Request #1629 · noobaa/noobaa-operator · GitHub
[go: up one dir, main page]
Skip to content

Bumping version from 5.19.0 to 5.20.0 #1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

Bumping version from 5.19.0 to 5.20.0 #1629

merged 1 commit into from
Jun 17, 2025

Conversation

@liranmauda
Copy link
Contributor
@liranmauda liranmauda commented Jun 16, 2025 •
edited by coderabbitai bot
Loading

Explain the changes

Bumping version from 5.19.0 to 5.20.0

Summary by CodeRabbit

  • Documentation

    • Updated documentation to reflect the new default version number 5.20.0 for the CLI and container images.

  • Chores

    • Bumped default version references from 5.19.0 to 5.20.0 throughout the application.

@liranmauda
Bumping version from 5.19.0 to 5.20.0
5ff4624 
Bumping version from 5.19.0 to 5.20.0

Signed-off-by: liranmauda <liran.mauda@gmail.com>
@coderabbitai
Copy link
coderabbitai bot commented Jun 16, 2025 •
edited
Loading

Walkthrough

The changes update version numbers from 5.19.0 to 5.20.0 across documentation and source code. This includes modifying constants in the codebase and updating references and examples in the README to reflect the new version.

Changes

Files/Paths Change Summary
README.md Updated default version numbers and CLI output examples from 5.19.0 to 5.20.0.
pkg/bundle/deploy.go, version/version.go Updated Version constant values from 5.19.0 to 5.20.0.
📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4ecadab and 5ff4624.

📒 Files selected for processing (3)
  • README.md (2 hunks)
  • pkg/bundle/deploy.go (1 hunks)
  • version/version.go (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: run-kms-kmip-test
🔇 Additional comments (4)
version/version.go (1)

5-5: Bump operator version to 5.20.0
Version constant correctly updated to 5.20.0.

Please verify that all other version references (e.g., “5.19.0”) have been updated accordingly:

#!/bin/bash
# Ensure no residual references to the old version
rg -n '5\.19\.0'
pkg/bundle/deploy.go (1)

3-3: Let’s locate the manifest (it may live elsewhere) and compute its SHA-256:

#!/bin/bash
# 1) Find any deploy_cluster_role.yaml in the repo
echo "Looking for deploy_cluster_role.yaml..."
find . -type f -iname 'deploy_cluster_role.yaml' || true

# 2) For each found file, compute its SHA-256 via Python
echo -e "\nComputing SHA-256 checksums:"
find . -type f -iname 'deploy_cluster_role.yaml' -print0 | while IFS= read -r -d '' file; do
  python3 - << EOF
import hashlib
path = "$file"
with open(path, "rb") as f:
    print(f"Actual SHA-256 for {path}: {hashlib.sha256(f.read()).hexdigest()}")
EOF
done
README.md (2)

157-158: Verify updated default image flags.

The default values for --noobaa-image and --operator-image have been bumped to 5.20.0. Confirm these defaults align with the new release artifacts and match the version constants in the code.

180-182: Approve updated version output example.

The example output for noobaa version now shows 5.20.0 for CLI, noobaa-image, and operator-image. This correctly reflects the bump to v5.20.0.

✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@liranmauda liranmauda merged commit d4ce419 into noobaa:master Jun 17, 2025
16 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Sep 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nimrod-becker nimrod-becker nimrod-becker approved these changes

@tangledbytes tangledbytes Awaiting requested review from tangledbytes

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liranmauda @nimrod-becker
0