8000 Fix: 修复 ForwardRef eval 时参数 recursive_guard 缺失 by he0119 · Pull Request #2778 · nonebot/nonebot2 · GitHub
[go: up one dir, main page]

Skip to content

Fix: 修复 ForwardRef eval 时参数 recursive_guard 缺失 #2778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

he0119
Copy link
Member
@he0119 he0119 commented Jun 19, 2024

参考 pydantic/pydantic#9612 进行修复。

Copy link
codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.18%. Comparing base (c8ba973) to head (869be6e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2778      +/-   ##
==========================================
- Coverage   94.20%   94.18%   -0.02%     
==========================================
  Files          48       48              
  Lines        4054     4044      -10     
==========================================
- Hits         3819     3809      -10     
  Misses        235      235              
Flag Coverage Δ
unittests 94.18% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor
github-actions bot commented Jun 19, 2024

🚀 Deployed on https://deploy-preview-2778--nonebot2.netlify.app

@github-actions github-actions bot temporarily deployed to pull request June 19, 2024 16:11 Inactive
RF-Tar-Railt
RF-Tar-Railt previously approved these changes Jun 19, 2024
@github-actions github-actions bot temporarily deployed to pull request June 20, 2024 04:33 Inactive
yanyongyu
yanyongyu previously approved these changes Jun 20, 2024
@yanyongyu yanyongyu added the bug Something isn't working label Jun 20, 2024
@yanyongyu yanyongyu changed the title Fix: ForwardRef._evaluate 中使用关键字参数来设置 recursive_guard Fix: 修复 ForwardRef eval 时参数 recursive_guard 缺失 Jun 20, 2024
@he0119 he0119 force-pushed the fix/evaluate-forwardref branch from 21c5aa6 to 869be6e Compare June 20, 2024 11:49
@github-actions github-actions bot temporarily deployed to pull request June 20, 2024 11:53 Inactive
@yanyongyu yanyongyu merged commit 62dc257 into master Jun 20, 2024
36 of 39 checks passed
@yanyongyu yanyongyu deleted the fix/evaluate-forwardref branch June 20, 2024 12:49
6734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

3 participants
0