8000 chore: add semantic commit check by dsanders11 · Pull Request #29 · nodejs/postject · GitHub
[go: up one dir, main page]
Skip to content

chore: add semantic commit check #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dsanders11 merged 2 commits into from
Sep 27, 2022
Merged

chore: add semantic commit check #29

dsanders11 merged 2 commits into from
Sep 27, 2022

Conversation

@dsanders11
Copy link
Contributor
@dsanders11 dsanders11 commented Sep 23, 2022

We've been using semantic commit messages for this project, let's enforce it.

RaisinTen
RaisinTen approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member
@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RaisinTen
Copy link
Member
RaisinTen commented Sep 26, 2022

Actually, one more question - does this allow commits that start with [skip ci] like in #28?

@dsanders11
Copy link
Contributor Author
dsanders11 commented Sep 27, 2022 •
edited
Loading

Actually, one more question - does this allow commits that start with [skip ci] like in #28?

I believe you would just need to put the [skip ci] somewhere else other than the start of the message, like on the end instead, which I think is preferable anyway since it keeps the starts of messages clean and easy to scan.

Actually looks like that's how the action author does it on their own commits: "chore: Release 4.6.0 [skip ci]"

@dsanders11 dsanders11 force-pushed the 98A8 semantic-commit-action branch from 249ce4c to 702aa5d Compare September 27, 2022 03:34
@dsanders11 dsanders11 merged commit a5fb07e into main Sep 27, 2022
@RaisinTen RaisinTen deleted the semantic-commit-action branch September 27, 2022 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@jviotti jviotti Awaiting requested review from jviotti jviotti is a code owner

@robertgzr robertgzr Awaiting requested review from robertgzr robertgzr is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dsanders11 @RaisinTen
0