8000 cli: refactor out cli.promptForInput by joyeecheung · Pull Request #300 · nodejs/node-core-utils · GitHub
[go: up one dir, main page]
Skip to content

cli: refactor out cli.promptForInput #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joyeecheung merged 1 commit into from
Nov 4, 2018
Merged

cli: refactor out cli.promptForInput #300

joyeecheung merged 1 commit into from
Nov 4, 2018

Conversation

@joyeecheung
< 8000 div id="pullrequest-228192964" class="timeline-comment-group js-minimizable-comment-group js-targetable-element my-0 comment previewable-edit js-task-list-container js-comment editable-comment timeline-comment--caret reorderable-task-lists timeline-comment ml-n3 unminimized-comment">
Copy link
Member
@joyeecheung joyeecheung commented Nov 4, 2018

No description provided.

@joyeecheung
Copy link
Member Author
joyeecheung commented Nov 4, 2018

cc @refack

@joyeecheung
Copy link
Member Author
joyeecheung commented Nov 4, 2018

Refs: #299

@codecov
Copy link
codecov bot commented Nov 4, 2018

Codecov Report

Merging #300 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #300   +/-   ##
=======================================
  Coverage   73.94%   73.94%           
=======================================
  Files          22       22           
  Lines        1401     1401           
=======================================
  Hits         1036     1036           
  Misses        365      365
Impacted Files Coverage Δ
lib/cli.js 52.11% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beccfee...7e34c79. Read the comment docs.

@refack refack mentioned this pull request Nov 4, 2018
Closed
@joyeecheung joyeecheung merged commit 17d70e5 into nodejs:master Nov 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@refack refack refack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joyeecheung @refack
0