test: use assert.strictEqual() #777
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickNaso
reviewed
Jul 27, 2020
Comment on lines
15
to
18
| assert.strictEqual(typeof await testCall({ blocking: true, data: true }) , "number"); | ||
| assert.strictEqual(typeof await testCall({ blocking: true, data: false }) , "undefined"); | ||
| assert.strictEqual(typeof await testCall({ blocking: false, data: true }) , "number"); | ||
| assert.strictEqual(typeof await testCall({ blocking: false, data: false }) , "undefined"); |
Member
There was a problem hiding this comment.
@Nishikoh could you remove the space before the comma ","?
Es.
assert.strictEqual(typeof await testCall({ blocking: false, data: false }), "undefined");
Contributor
Author
There was a problem hiding this comment.
Thank you for the review. Fixed it.
gabrielschulhof
approved these changes
Jul 27, 2020
Contributor
Contributor
|
On v15.x it fails for unrelated reasons – specifically, because the |
Contributor
|
Rebased. |
Contributor
Contributor
|
Landed in 4ce40d2. |
kevindavies8
added a commit
to kevindavies8/node-addon-api-Develop
that referenced
this pull request
Aug 24, 2022
Fixes: nodejs/node-addon-api#775 PR-URL: nodejs/node-addon-api#777 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Marlyfleitas
added a commit
to Marlyfleitas/node-api-addon-Development
that referenced
this pull request
Aug 26, 2022
Fixes: nodejs/node-addon-api#775 PR-URL: nodejs/node-addon-api#777 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
wroy7860
added a commit
to wroy7860/addon-api-benchmark-node
that referenced
this pull request
Sep 19, 2022
Fixes: nodejs/node-addon-api#775 PR-URL: nodejs/node-addon-api#777 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
johnfrench3
pushed a commit
to johnfrench3/node-addon-api-git
that referenced
this pull request
Aug 11, 2023
Fixes: nodejs/node-addon-api#775 PR-URL: nodejs/node-addon-api#777 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #775