8000 doc: fix rendering of code blocks in list by tniessen · Pull Request #1401 · nodejs/node-addon-api · GitHub
[go: up one dir, main page]

Skip to content

Conversation

tniessen
Copy link
Member
@tniessen tniessen commented Nov 2, 2023

Without proper indentation, some paragraphs would be rendered as code blocks:

screenshot showing incorrect rendering

8000

@tniessen tniessen added the doc label Nov 2, 2023
Copy link
Member
@legendecas legendecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

8000
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
@tniessen
Copy link
Member Author
tniessen commented Nov 3, 2023

CI keeps failing with No module named 'distutils'

@tniessen
Copy link
Member Author
tniessen commented Nov 3, 2023

Likely due to nodejs/node-gyp#2869. How do we upgrade node-gyp to pull in nodejs/node-gyp#2923?

@legendecas
Copy link
Member

Locking python version in GitHub actions: #1403

@legendecas
Copy link
Member

node-gyp is bundled with npm. npm v10 dropped support for Node.js v14 and v16. So I'm going to simply lock the python version on GitHub actions, to avoid breakage in the future as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0