8000 fix: handle c++ exception in TSFN callback by legendecas · Pull Request #1345 · nodejs/node-addon-api · GitHub
[go: up one dir, main page]
Skip to content

fix: handle c++ exception in TSFN callback #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 25, 2023
Merged

fix: handle c++ exception in TSFN callback #1345

merged 3 commits into from
Jul 25, 2023

Conversation

legendecas
Copy link
Member

Rethrow Napi::Error exceptions as node-api exceptions at the boundary of TSFN callback.

Fixes: #1119

mhdawson
mhdawson approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member
@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson mentioned this pull request Jul 14, 2023
Open
gabrielschulhof
gabrielschulhof reviewed Jul 14, 2023
View reviewed changes
test/threadsafe_function/threadsafe_function_exception.js
@@ -0,0 +1,55 @@
'use strict';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: For the tests, you could use common.runTestInChildProcess(). You need to extend it to also accept Node.js command line arguments, but I think it might make the code a little cleaner.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, thanks for the suggestion! It's definitely an improvement after #1325 landed.

KevinEady
KevinEady approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor
@KevinEady KevinEady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legendecas legendecas merged commit 16a18c0 into nodejs:main Jul 25, 2023
@legendecas legendecas deleted the tsfn branch July 25, 2023 15:14
@snyk-io snyk-io bot mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabrielschulhof gabrielschulhof gabrielschulhof left review comments

@KevinEady KevinEady KevinEady approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ThreadSafeFunction should handle exceptions in async callbacks identical to Node itself

4 participants

@legendecas @gabrielschulhof @KevinEady @mhdawson
0