10BC0 Add regex check to error expectation by samshull · Pull Request #9949 · nodejs/node · GitHub
[go: up one dir, main page]
Skip to content

Add regex check to error expectation #9949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
samshull wants to merge 0 commits into from
Closed

Add regex check to error expectation #9949

samshull wants to merge 0 commits into from

Conversation

@samshull
Copy link
7440
@samshull samshull commented Dec 1, 2016
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Description of change

Add regex check to error expectation that matches the expected error message.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdex
Copy link
Contributor
mscdex commented Dec 1, 2016

Please follow the commit message guidelines here.

@mscdex mscdex added the buffer Issues and PRs related to the buffer subsystem. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@samshull
Copy link
Author
samshull commented Dec 1, 2016

@mscdex updated explanation

@samshull samshull closed this Dec 1, 2016
@samshull
Copy link
Author
samshull commented Dec 1, 2016

Closed in favor of #10038

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@samshull @mscdex @imyller @nodejs-github-bot
0