8000 test: replace equal with strictEqual by julianduque · Pull Request #9879 · nodejs/node · GitHub
  • [go: up one dir, main page]
    Skip to content

    test: replace equal with strictEqual #9879

    New issue

    Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

    Sign up for GitHub

    By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

    Already on GitHub? Sign in to your account

    Jump to bottom
    Closed
    julianduque wants to merge 1 commit into from
    Closed

    test: replace equal with strictEqual #9879

    julianduque wants to merge 1 commit into from
    +4 −4

    Conversation

    @julianduque
    Copy link
    Contributor
    @julianduque julianduque commented Dec 1, 2016 •
    edited
    Loading
    Checklist
    • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
    • commit message follows commit guidelines
    Affected core subsystem(s)

    test

    Description of change

    Replace assert.equal with assert.strictEqual

    @julianduque
    test: replace equal with strictEqual
    b0e397a 
    Replace assert.equal with assert.strictEqual
    @nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
    @mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label Dec 1, 2016
    @imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
    @Trott
    Copy link
    Member
    Trott commented Dec 1, 2016

    CI: https://ci.nodejs.org/job/node-test-pull-request/5055/

    jasnell
    jasnell approved these changes Dec 3, 2016
    View reviewed changes
    Copy link
    Member
    @jasnell jasnell left a comment •
    edited
    Loading

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM. Thank you for the PR and for participating in Code and Learn!

    jasnell pushed a commit that referenced this pull request Dec 4, 2016
    @julianduque @jasnell
    test: replace equal with strictEqual
    318f345 
    Replace assert.equal with assert.strictEqual

PR-URL: #9879
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @jasnell
    < 8000 details-menu class="dropdown-menu dropdown-menu-sw show-more-popover color-fg-default" style="width:185px" src="" preload > Copy link
    Member
    jasnell commented Dec 4, 2016

    Landed in 318f345. Thank you!

    @jasnell jasnell closed this Dec 4, 2016
    addaleax pushed a commit that referenced this pull request Dec 5, 2016
    @julianduque @addaleax
    test: replace equal with strictEqual
    3d35930 
    Replace assert.equal with assert.strictEqual

PR-URL: #9879
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
    Merged
    2 tasks
    addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
    @julianduque @addaleax
    test: replace equal with strictEqual
    0c66f68 
    Replace assert.equal with assert.strictEqual

PR-URL: nodejs#9879
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
    @julianduque
    test: replace equal with strictEqual
    9ca9842 
    Replace assert.equal with assert.strictEqual

PR-URL: nodejs#9879
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
    @julianduque @MylesBorins
    test: replace equal with strictEqual
    49900e7 
    Replace assert.equal with assert.strictEqual

PR-URL: #9879
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
    @julianduque @MylesBorins
    test: replace equal with strictEqual
    8ce2b04 
    Replace assert.equal with assert.strictEqual

PR-URL: #9879
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
    @julianduque @MylesBorins
    test: replace equal with strictEqual
    8fc65e5 
    Replace assert.equal with assert.strictEqual

PR-URL: #9879
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    This was referenced Dec 21, 2016
    Merged
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @jasnell jasnell jasnell approved these changes

    @lpinca lpinca lpinca approved these changes

    @targos targos targos approved these changes

    @cjihrig cjihrig cjihrig approved these changes

    Assignees

    No one assigned

    Labels

    child_process Issues and PRs related to the child_process subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.
    0