8000 Update util.md for ES6 extends code example by shaikh-shahid · Pull Request #8183 · nodejs/node · GitHub
[go: up one dir, main page]
Skip to content

Update util.md for ES6 extends code example #8183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shaikh-shahid wants to merge 2 commits into from
Closed

Update util.md for ES6 extends code example #8183

shaikh-shahid wants to merge 2 commits into from

Conversation

@shaikh-shahid
Copy link
Contributor
@shaikh-shahid shaikh-shahid commented Aug 19, 2016 •
edited
Loading
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@nodejs-github-bot nodejs-github-bot added util Issues and PRs related to the built-in util module. doc Issues and PRs related to the documentations. labels Aug 19, 2016
yorkie
yorkie reviewed Aug 19, 2016
View reviewed changes
doc/api/util.md Outdated

ES6 example using class and extends

```
Copy link
Contributor
@yorkie yorkie Aug 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code class js or es6 is missing?

@jasnell
Copy link
Member
jasnell commented Aug 19, 2016

LGTM /cc @nodejs/documentation

@yorkie
Copy link
Contributor
yorkie commented Aug 20, 2016

LGTM

1 similar comment
@eljefedelrodeodeljefe
Copy link
Contributor
eljefedelrodeodeljefe commented Aug 20, 2016

LGTM

jasnell 8000 pushed a commit that referenced this pull request Aug 21, 2016
@shaikh-shahid @jasnell
doc: add es6 code example in util.md
9a91ffb 
Added class/extends example to util.md

PR-URL: #8183
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
@jasnell
Copy link
Member
jasnell commented Aug 21, 2016

Landed in 9a91ffb! thank you!
I did fix up the commit message to follow our contribution guide.

@jasnell jasnell closed this Aug 21, 2016
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
@shaikh-shahid @evanlucas
doc: add es6 code example in util.md
afbe4d8 
Added class/extends example to util.md

PR-URL: #8183
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
@evanlucas evanlucas mentioned this pull request Aug 24, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@shaikh-shahid @jasnell @yorkie @eljefedelrodeodeljefe @MylesBorins @nodejs-github-bot
0