8000 test: use strict equality in regression test by Trott · Pull Request #8098 · nodejs/node · GitHub
  • [go: up one dir, main page]
    Skip to content

    test: use strict equality in regression test #8098

    New issue

    Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

    Sign up for GitHub

    By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

    Already on GitHub? Sign in to your account

    Jump to bottom
    Closed
    Trott wants to merge 1 commit into from
    Closed

    test: use strict equality in regression test #8098

    Trott wants to merge 1 commit into from

    Conversation

    @Trott
    Copy link
    Member
    @Trott Trott commented Aug 14, 2016
    Checklist
    • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
    • commit message follows commit guidelines
    Affected core subsystem(s)

    test

    Description of change

    Replace == with === and assert.strictEqual() in
    test-regress-GH-877.js.

    @Trott
    test: use strict equality in regression test
    344fbfe 
    Replace `==` with `===` and `assert.strictEqual()` in
test-regress-nodejsGH-877.js.
    @Trott Trott added the test Issues and PRs related to the tests. label Aug 14, 2016
    @targos
    Copy link
    Member
    targos commented Aug 14, 2016

    LGTM

    4 similar comments
    @fhinkel
    Copy link
    Member
    fhinkel commented Aug 14, 2016

    LGTM

    @cjihrig
    Copy link
    Contributor
    cjihrig commented Aug 15, 2016

    LGTM

    @jasnell
    Copy link
    Member
    jasnell commented Aug 15, 2016

    LGTM

    @santigimeno
    Copy link
    Member
    santigimeno commented Aug 15, 2016

    LGTM

    @Trott
    Copy link
    Member Author
    Trott commented Aug 16, 2016

    CI is yellow on AIX flaky test, green everywhere else: https://ci.nodejs.org/job/node-test-pull-request/3665/

    Trott added a commit to Trott/io.js that referenced this pull request Aug 17, 2016
    @Trott
    test: use strict equality in regression test
    8badb67 
    Replace `==` with `===` and `assert.strictEqual()` in
test-regress-nodejsGH-877.js.

PR-URL: nodejs#8098
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    @Trott
    Copy link
    Member Author
    Trott commented Aug 17, 2016

    Landed in 8badb67

    @Trott Trott closed this Aug 17, 2016
    evanlucas pushed a commit that referenced this pull request Aug 20, 2016
    @Trott @evanlucas
    test: use strict equality in regression test
    6bdc0e5 
    Replace `==` with `===` and `assert.strictEqual()` in
test-regress-GH-877.js.

PR-URL: #8098
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    @evanlucas evanlucas mentioned this pull request Aug 24, 2016
    Merged
    MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
    @Trott
    test: use strict equality in regression test
    9e7a386 
    Replace `==` with `===` and `assert.strictEqual()` in
test-regress-GH-877.js.

PR-URL: #8098
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    rvagg pushed a commit that referenced this pull request Oct 18, 2016
    @Trott @rvagg
    test: use strict equality in regression test
    ac19961 
    Replace `==` with `===` and `assert.strictEqual()` in
test-regress-GH-877.js.

PR-URL: #8098
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
    @Trott @MylesBorins
    test: use strict equality in regression test
    b063dc9 
    Replace `==` with `===` and `assert.strictEqual()` in
test-regress-GH-877.js.

PR-URL: #8098
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
    @MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
    Closed
    @Trott Trott deleted the stricteqeqeq branch January 13, 2022 22:44
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    test Issues and PRs related to the tests.

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    7 participants

    @Trott @targos @fhinkel @cjihrig @jasnell @santigimeno @MylesBorins
    0