8000 src: renaming ares_task struct to node_ares_task by danbev · Pull Request #7345 · nodejs/node · GitHub
  • [go: up one dir, main page]
    Skip to content

    src: renaming ares_task struct to node_ares_task #7345

    New issue

    Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

    Sign up for GitHub

    By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

    Already on GitHub? Sign in to your account

    Jump to bottom
    Closed
    danbev wants to merge 1 commit into from
    Closed

    src: renaming ares_task struct to node_ares_task #7345

    danbev wants to merge 1 commit into from

    Conversation

    @danbev
    Copy link
    Contributor
    @danbev danbev commented Jun 20, 2016
    Checklist
    • make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
    • the commit message follows commit guidelines
    Affected core subsystem(s)

    src

    Description of change

    This commit attempts to fix one of the items in
    #4641, which was to remove a TODO
    comment from env.h regarding the naming of the ares_task_t struct.

    Also, the struct ares_task_list was renamed to node_ares_task_list
    following the same reasoning that is does not belong to the c-ares API.

    @danbev
    src: renaming ares_task struct to node_ares_task
    c9edf62 
    This commit attempts to fix one of the items in
nodejs#4641, which was to remove a TODO
comment from env.h regarding the naming of the ares_task_t struct.

Also, the struct ares_task_list was renamed to node_ares_task_list
following the same reasoning that is does not belong to the c-ares API.
    @nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 20, 2016
    @MylesBorins
    Copy link
    Contributor
    MylesBorins commented Jun 20, 2016

    ci: https://ci.nodejs.org/job/node-test-pull-request/3036/

    @mscdex
    Copy link
    Contributor
    mscdex commented Jun 20, 2016

    /cc @bnoordhuis

    LGTM

    @cjihrig
    Copy link
    Contributor
    cjihrig commented Jun 20, 2016

    LGTM

    @mscdex mscdex added the dns Issues and PRs related to the dns subsystem. label Jun 21, 2016
    @addaleax
    Copy link
    Member
    addaleax commented Jun 24, 2016

    LGTM

    @jasnell
    Copy link
    Member
    jasnell commented Jun 27, 2016

    LGTM

    @jasnell
    Copy link
    Member
    jasnell commented Jun 27, 2016

    @bnoordhuis ... does this LGTY?

    @bnoordhuis bnoordhuis removed their assignment Jun 27, 2016
    @bnoordhuis
    Copy link
    Member
    bnoordhuis commented Jun 27, 2016

    LGTM

    jasnell pushed a commit that referenced this pull request Jun 27, 2016
    @danbev @jasnell
    src: renaming ares_task struct to node_ares_task
    5615487 
    This commit attempts to fix one of the items in
#4641, which was to remove a TODO
comment from env.h regarding the naming of the ares_task_t struct.

Also, the struct ares_task_list was renamed to node_ares_task_list
following the same reasoning that is does not belong to the c-ares API.

PR-URL: #7345
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @jasnell
    Copy link
    Member
    jasnell commented Jun 27, 2016

    Landed in 5615487

    @jasnell jasnell closed this Jun 27, 2016
    @danbev danbev deleted the rename-ares-task-struct branch June 30, 2016 16:12
    Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
    @danbev @Fishrock123
    src: renaming ares_task struct to node_ares_task
    84dd526 
    This commit attempts to fix one of the items in
#4641, which was to remove a TODO
comment from env.h regarding the naming of the ares_task_t struct.

Also, the struct ares_task_list was renamed to node_ares_task_list
following the same reasoning that is does not belong to the c-ares API.

PR-URL: #7345
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

 Conflicts:
	src/env.h
    @Fishrock123 Fishrock123 mentioned this pull request Jul 5, 2016
    Merged
    @MylesBorins MylesBorins mentioned this pull request Jul 11, 2016
    Closed
    @MylesBorins
    Copy link
    Contributor
    MylesBorins commented Jul 11, 2016

    @addaleax @bnoordhuis lts?

    @addaleax
    Copy link
    Member
    addaleax commented Jul 12, 2016

    @thealphanerd Yes… if it doesn’t land cleanly I can backport.

    @MylesBorins
    Copy link
    Contributor
    MylesBorins commented Jul 12, 2016

    @addaleax it will need a manual backport thank you. 😄

    @addaleax addaleax mentioned this pull request Jul 12, 2016
    Closed
    @addaleax
    Copy link
    Member
    addaleax commented Jul 12, 2016

    Backport is in #7669

    addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
    @danbev @addaleax
    src: renaming ares_task struct to node_ares_task
    ee1461f 
    This commit attempts to fix one of the items in
nodejs#4641, which was to remove a TODO
comment from env.h regarding the naming of the ares_task_t struct.

Also, the struct ares_task_list was renamed to node_ares_task_list
following the same reasoning that is does not belong to the c-ares API.

PR-URL: nodejs#7345
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    addaleax pushed a commit to addaleax/node that referenced this pull request Nov 22, 2016
    @danbev @addaleax
    src: renaming ares_task struct to node_ares_task
    b984e4e 
    This commit attempts to fix one of the items in
nodejs#4641, which was to remove a TODO
comment from env.h regarding the naming of the ares_task_t struct.

Also, the struct ares_task_list was renamed to node_ares_task_list
following the same reasoning that is does not belong to the c-ares API.

PR-URL: nodejs#7345
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @addaleax addaleax mentioned this pull request Nov 22, 2016
    Closed
    MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
    @danbev
    src: renaming ares_task struct to node_ares_task
    3b5cede 
    This commit attempts to fix one of the items in
#4641, which was to remove a TODO
comment from env.h regarding the naming of the ares_task_t struct.

Also, the struct ares_task_list was renamed to node_ares_task_list
following the same reasoning that is does not belong to the c-ares API.

PR-URL: #7345
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @MylesBorins MylesBorins mentioned this pull request Nov 22, 2016
    Merged
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    c++ Issues and PRs that require attention from people who are familiar with C++. dns Issues and PRs related to the dns subsystem.

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    8 participants

    @danbev @MylesBorins @mscdex @cjihrig @addaleax @jasnell @bnoordhuis @nodejs-github-bot
    0