test_runner: fix test enqueue when test file has syntax error#61573
Merged
nodejs-github-bot merged 5 commits intonodejs:mainfrom Feb 2, 2026
Merged
test_runner: fix test enqueue when test file has syntax error#61573nodejs-github-bot merged 5 commits intonodejs:mainfrom
nodejs-github-bot merged 5 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61573 +/- ##
==========================================
+ Coverage 88.52% 89.75% +1.23%
==========================================
Files 704 673 -31
Lines 208863 203843 -5020
Branches 40335 39179 -1156
==========================================
- Hits 184905 182969 -1936
+ Misses 15928 13196 -2732
+ Partials 8030 7678 -352
🚀 New features to boost your workflow:
|
MoLow
approved these changes
Jan 29, 2026
avivkeller
reviewed
Jan 29, 2026
avivkeller
reviewed
Jan 29, 2026
avivkeller
approved these changes
Jan 29, 2026
pmarchini
reviewed
Jan 29, 2026
| const { spawnSync } = require('node:child_process'); | ||
| const fixtures = require('../common/fixtures'); | ||
|
|
||
| const testFile = fixtures.path('test-runner', 'syntax-error-test.mjs'); |
Member
There was a problem hiding this comment.
As the original issue states "test:enqueue event has no file field", should we cover it with a test?
22983f0 to
1e6e3dd
Compare
pmarchini
approved these changes
Jan 30, 2026
Collaborator
Collaborator
Collaborator
|
Landed in 61a4a30 |
aduh95
pushed a commit
that referenced
this pull request
Feb 8, 2026
PR-URL: #61573 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61565
Add location to the test placeholder