8000 2025-11-17, Version 25.2.1 (Current) by github-actions[bot] · Pull Request #60752 · nodejs/node · GitHub
[go: up one dir, main page]
Skip to content

2025-11-17, Version 25.2.1 (Current) #60752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aduh95 merged 5 commits into from
Nov 17, 2025
Merged

2025-11-17, Version 25.2.1 (Current) #60752

aduh95 merged 5 commits into from
Nov 17, 2025

Conversation

@github-actions
Copy link
Contributor
@github-actions github-actions bot commented Nov 16, 2025 •
edited by aduh95
Loading

Notable Changes

  • [a4dee613fd] - Revert "lib: throw from localStorage getter on missing storage path" (Antoine du Hamel) #60750

Commits

  • [ff89b7b6c7] - crypto: ensure documented RSA-PSS saltLength default is used (Filip Skokan) #60662
  • [5316b580eb] - deps: V8: backport 2e4c5cf9b112 (Michaël Zasso) #60654
  • [ca878bc90e] - doc,src,lib: clarify experimental status of Web Storage support (Antoine du Hamel) #60708

targos and others added 5 commits November 14, 2025 13:28
@targos @richardlau
deps: V8: backport 2e4c5cf9b112
5316b58 
Original commit message:

    remove ppc and s390 from the host_arch list

    We only support ppc64 and s390x.
    Same changes is applied to depot_tools:
    http://crrev.com/c/7100932

    Change-Id: I1e4b660a1e46d1c609189301e8fd977fb7434748
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7102361
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Milad Farazmand <mfarazma@ibm.com>
    Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#103488}

Refs: v8/v8@2e4c5cf
Fixes: nodejs/build#4184
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: #60654
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
@aduh95
Revert "lib: throw from localStorage getter on missing storage path"
a4dee61 
This reverts commit 4fbb1ab.

PR-URL: #60750
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@aduh95
doc,src,lib: clarify experimental status of Web Storage support
ca878bc 
PR-URL: #60708
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@panva @aduh95
crypto: ensure documented RSA-PSS saltLength default is used
ff89b7b 
PR-URL: #60662
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot
2025-11-17, Version 25.2.1 (Current)
4cac2b9 
Notable changes:

PR-URL: #60752
@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Nov 16, 2025

Review requested:

  • @nodejs/config
  • @nodejs/crypto
  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@github-actions github-actions bot added release Issues and PRs related to Node.js releases. v25.x Issues that can be reproduced on v25.x or PRs targeting the v25.x-staging branch. labels Nov 16, 2025
@aduh95 aduh95 marked this pull request as ready for review November 16, 2025 19:57
@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Nov 16, 2025 •
edited by aduh95
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/70209/
CITGM(v25.x): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3658/
CITGM(v25.2.1-proposal): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3659/
📦: https://ci-release.nodejs.org/job/iojs+release/11398/

@codecov
Copy link
codecov bot commented Nov 16, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 86.11111% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.53%. Comparing base (cc33907) to head (4cac2b9).
⚠️ Report is 7 commits behind head on v25.x.

Files with missing lines Patch % Lines
lib/internal/webstorage.js 80.76% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##            v25.x   #60752      +/-   ##
==========================================
- Coverage   88.54%   88.53%   -0.02%     
==========================================
  Files         703      703              
  Lines      207885   207908      +23     
  Branches    40053    40046       -7     
==========================================
- Hits       184081   184075       -6     
- Misses      15838    15858      +20     
- Partials     7966     7975       +9
Files with missing lines Coverage Δ
lib/internal/crypto/sig.js 95.74% <100.00%> (+0.07%) ⬆️
lib/internal/process/pre_execution.js 98.53% <100.00%> (ø)
src/node_options.cc 77.85% <100.00%> (ø)
lib/internal/webstorage.js 91.30% <80.76%> (-8.70%) ⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 merged commit 4cac2b9 into v25.x Nov 17, 2025
80 checks passed
aduh95 added a commit that referenced this pull request Nov 17, 2025
@aduh95
Working on v25.2.2
fc996fd 
PR-URL: #60752
aduh95 pushed a commit that referenced this pull request Nov 17, 2025
@nodejs-github-bot @aduh95
2025-11-17, Version 25.2.1 (Current)
420b627 
Notable changes:

PR-URL: #60752
@aduh95 aduh95 deleted the v25.2.1-proposal branch November 17, 2025 09:37
dofaromg
dofaromg reviewed Nov 23, 2025
View reviewed changes
Copy link
@dofaromg dofaromg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

cmartstores-lab
cmartstores-lab reviewed Dec 9, 2025
View reviewed changes
Copy link
@cmartstores-lab cmartstores-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes

+2 more reviewers

@dofaromg dofaromg dofaromg left review comments

@cmartstores-lab cmartstores-lab cmartstores-lab left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@aduh95 aduh95

Labels

release Issues and PRs related to Node.js releases. v25.x Issues that can be reproduced on v25.x or PRs targeting the v25.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@nodejs-github-bot @anonrig @dofaromg @cmartstores-lab @aduh95 @targos @panva
0