10BC0 repl: fix pasting after moving the cursor to the left by BridgeAR · Pull Request #60470 · nodejs/node · GitHub
[go: up one dir, main page]
Skip to content

repl: fix pasting after moving the cursor to the left #60470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Nov 5, 2025
+16 −1
Merged

repl: fix pasting after moving the cursor to the left #60470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/internal/readline/interface.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,7 +659,17 @@ class Interface extends InterfaceConstructor {
[kInsertString](c) {
this[kBeforeEdit](this.line, this.cursor);
if (!this.isCompletionEnabled) {
this.line += c;
if (this.cursor < this.line.length) {
const beg = StringPrototypeSlice(this.line, 0, this.cursor);
const end = StringPrototypeSlice(
this.line,
this.cursor,
this.line.length,
);
this.line = beg + c + end;
} else {
this.line += c;
}
this.cursor += c.length;
this[kWriteToOutput](c);
return;
Expand Down
5 changes: 5 additions & 0 deletions test/parallel/test-repl-paste-big-data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ const { startNewREPLServer } = require('../common/repl');
const cpuUsage = process.cpuUsage();

const { replServer } = startNewREPLServer({}, { disableDomainErrorAssert: true });
replServer.input.emit('data', '{}');
replServer.input.emit('keypress', '', { name: 'left' });
replServer.input.emit('data', 'node');
assert.strictEqual(replServer.line, '{node}');

replServer.input.emit('data', 'a'.repeat(2e4) + '\n');
replServer.input.emit('data', '.exit\n');

Expand Down
Loading
0