8000 src: replace Environment::GetCurrent with args.GetIsolate by KimSH39 · Pull Request #60256 · nodejs/node · GitHub
[go: up one dir, main page]
Skip to content

src: replace Environment::GetCurrent with args.GetIsolate #60256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Oct 18, 2025
Merged

src: replace Environment::GetCurrent with args.GetIsolate #60256

nodejs-github-bot merged 1 commit into from
Oct 18, 2025

Conversation

@KimSH39
Copy link
Contributor
@KimSH39 KimSH39 commented Oct 14, 2025

Refactor code in node_util.cc and uv.cc to remove unnecessary calls to Environment::GetCurrent(args). Instead, use args.GetIsolate() and isolate->GetCurrentContext() where applicable to reduce extra lookups and improve readability.

No functional change.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Oct 14, 2025
@KimSH39 KimSH39 force-pushed the util-uv-use-args-isolate branch from 1ba6485 to a344fff Compare October 14, 2025 15:59
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 14, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 14, 2025
@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Oct 14, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69727/

@codecov
Copy link
codecov bot commented Oct 14, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.55%. Comparing base (0c35aaf) to head (a344fff).
⚠️ Report is 25 commits behind head on main.

Files with missing lines Patch % Lines
src/node_util.cc 87.50% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60256      +/-   ##
==========================================
- Coverage   88.57%   88.55%   -0.02%     
==========================================
  Files         704      704              
  Lines      208183   208184       +1     
  Branches    40015    40019       +4     
==========================================
- Hits       184404   184364      -40     
- Misses      15808    15859      +51     
+ Partials     7971     7961      -10
Files with missing lines Coverage Δ
src/uv.cc 90.76% <100.00%> (+0.14%) ⬆️
src/node_util.cc 80.37% <87.50%> (ø)

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Oct 15, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69732/

@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Oct 15, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69736/

@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Oct 16, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69764/

@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Oct 18, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/69804/

@daeyeon daeyeon added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 18, 2025