8000 [v22.x backport] Wasm ESM Integration PRs & Unflagging by guybedford · Pull Request #59179 · nodejs/node · GitHub
[go: up one dir, main page]
Skip to content

[v22.x backport] Wasm ESM Integration PRs & Unflagging #59179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
guybedford wants to merge 2 commits into from
Closed

[v22.x backport] Wasm ESM Integration PRs & Unflagging #59179

guybedford wants to merge 2 commits into from

Conversation

@guybedford
Copy link
Contributor
@guybedford guybedford commented Jul 22, 2025 •
edited
Loading

Backports:

This does not include source phase imports support as this was a later v8 feature.

This only reflects the unflagging of the experimental instance phase, and the backport is updated to reflect that.

JS String Builtins is possible to support with a very small polyfill layer allowing the implementation to match and pass the tests from v24.

@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Jul 22, 2025

Review requested:

  • @nodejs/config
  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Jul 22, 2025
@guybedford guybedford force-pushed the esm-integration-unflag-backport branch from b6d4790 to 8a5a312 Compare July 23, 2025 18:52
@guybedford guybedford changed the title [v22.x backport] esm: unflag --experimental-wasm-modules [v22.x backport] Wasm ESM Integration PRs & Unflagging Jul 23, 2025
@guybedford guybedford force-pushed the esm-integration-unflag-backport branch from 8a5a312 to d069903 Compare July 23, 2025 21:16
@guybedford guybedford force-pushed the esm-integration-unflag-backport branch from d069903 to d5ff7ea Compare July 25, 2025 16:25
@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Jul 25, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68198/

@ryanaslett
Copy link
ryanaslett commented Jul 25, 2025

This is the first PR to run after re-enabling OSX testing.

@aduh95
Copy link
Contributor
aduh95 commented Jul 28, 2025 •
edited
Loading

Could you please rebase? Also, #59020 is labeled dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. , do we actually want to include it?

@guybedford guybedford force-pushed the esm-integration-unflag-backport branch from d5ff7ea to fc09828 Compare July 28, 2025 19:56
@guybedford
Copy link
Contributor Author
guybedford commented Jul 28, 2025 •
edited
Loading

@aduh95 sure, this is now rebased. I initially added that label when I thought string builtins was not implementable, but it was trivial to include the polyfill. Aligning the semantics for instances between 22 and 24 feels like a win to me here, so I think it could be worthwhile.

@guybedford guybedford force-pushed the esm-integration-unflag-backport branch from fc09828 to cb08197 Compare July 30, 2025 02:01
@guybedford
Copy link
Contributor Author
guybedford 8000 commented Jul 30, 2025

It actually turns out we can use the V8 flag here instead of including the polyfill for string builtins, so rebasing #59020 was actually much easier than I originally implemented too.

@guybedford guybedford force-pushed the esm-integration-unflag-backport branch from cb08197 to c25ba79 Compare July 30, 2025 02:04
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@guybedford guybedford force-pushed the esm-integration-unflag-backport branch from c25ba79 to 208e26d Compare July 30, 2025 03:55
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Aug 3, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68388/

@guybedford guybedford force-pushed the esm-integration-unflag-backport branch from 208e26d to a9736da Compare August 5, 2025 18:08
@guybedford
esm: js-string Wasm builtins in ESM Integration
dcbda7e 
PR-URL: nodejs#59020
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@guybedford guybedford force-pushed the esm-integration-unflag-backport branch 2 times, most recently from b2ebc0d to d6de6cd Compare August 6, 2025 00:46
@guybedford
esm: unflag --experimental-wasm-modules
6f42a72 
PR-URL: nodejs#57038
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@guybedford guybedford force-pushed the esm-integration-unflag-backport branch from d6de6cd to 6f42a72 Compare August 6, 2025 01:43
@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Aug 6, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68444/

@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Aug 21, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68786/

@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Aug 21, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68792/

@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Aug 21, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68795/

@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Aug 21, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68800/

@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Aug 21, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68801/

@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Aug 22, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68808/

@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Aug 22, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68813/

@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Aug 22, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68815/

@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Aug 22, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68816/

@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Aug 22, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68818/

@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Aug 25, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68866/

@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Aug 26, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68869/

@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Aug 26, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68880/

@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Aug 26, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68882/

@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Aug 26, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68885/

@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Aug 26, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/68895/

aduh95 pushed a commit that referenced this pull request Aug 26, 2025
@guybedford @aduh95
esm: js-string Wasm builtins in ESM Integration
177ed3b 
PR-URL: #59020
Backport-PR-URL: #59179
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 26, 2025
@guybedford @aduh95
esm: unflag --experimental-wasm-modules
fa9a9e9 
PR-URL: #57038
Backport-PR-URL: #59179
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@aduh95
Copy link
Contributor
aduh95 commented Aug 26, 2025

Landed in f64f5df...fa9a9e9

@aduh95 aduh95 closed this Aug 26, 2025
codebytere added a commit to electron/electron that referenced this pull request Sep 5, 2025
@codebytere
esm: js-string Wasm builtins in ESM Integration
23e7793 
nodejs/node#59179
jkleinsc pushed a commit to electron/electron that referenced this pull request Sep 5, 2025
@electron-roller @codebytere
chore: bump node to v22.19.0 (main) (#48222)
1f322eb 
* chore: bump node in DEPS to v22.19.0

* chore: fixup patch indices

* crypto: add tls.setDefaultCACertificates()

nodejs/node#58822

* esm: js-string Wasm builtins in ESM Integration

nodejs/node#59179

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
dodolalorc pushed a commit to dodolalorc/electron that referenced this pull request Sep 11, 2025
@electron-roller @codebytere @dodolalorc
chore: bump node to v22.19.0 (main) (electron#48222)
1001336 
* chore: bump node in DEPS to v22.19.0

* chore: fixup patch indices

* crypto: add tls.setDefaultCACertificates()

nodejs/node#58822

* esm: js-string Wasm builtins in ESM Integration

nodejs/node#59179

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
kigh-ota pushed a commit to kigh-ota/electron that referenced this pull request Sep 30, 2025
@electron-roller @codebytere @kigh-ota
chore: bump node to v22.19.0 (main) (electron#48222)
29b5810 
* chore: bump node in DEPS to v22.19.0

* chore: fixup patch indices

* crypto: add tls.setDefaultCACertificates()

nodejs/node#58822

* esm: js-string Wasm builtins in ESM Integration

nodejs/node#59179

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
nilayarya pushed a commit to nilayarya/electron that referenced this pull request Nov 21, 2025
@electron-roller @codebytere
chore: bump node to v22.19.0 (main) (electron#48222)
2af95f7 
* chore: bump node in DEPS to v22.19.0

* chore: fixup patch indices

* crypto: add tls.setDefaultCACertificates()

nodejs/node#58822

* esm: js-string Wasm builtins in ESM Integration

nodejs/node#59179

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
nilayarya added a commit to nilayarya/electron that referenced this pull request Nov 21, 2025
@nilayarya @electron-roller @codebytere
chore: bump node to v22.19.0 (main) (electron#48222)
a1bf0c7 
* chore: bump node in DEPS to v22.19.0

* chore: fixup patch indices

* crypto: add tls.setDefaultCACertificates()

nodejs/node#58822

* esm: js-string Wasm builtins in ESM Integration

nodejs/node#59179

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
nilayarya added a commit to nilayarya/electron that referenced this pull request Nov 21, 2025
@nilayarya @electron-roller @codebytere
chore: bump node to v22.19.0 (main) (electron#48222)
474ef4f 
* chore: bump node in DEPS to v22.19.0

* chore: fixup patch indices

* crypto: add tls.setDefaultCACertificates()

nodejs/node#58822

* esm: js-string Wasm builtins in ESM Integration

nodejs/node#59179

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@guybedford @nodejs-github-bot @ryanaslett @aduh95
0