fs: throw ERR_INVALID_THIS on illegal invocations
#58848
Merged
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanarbol
approved these changes
Jun 26, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58848 +/- ##
==========================================
- Coverage 90.09% 90.09% -0.01%
==========================================
Files 640 640
Lines 188271 188454 +183
Branches 36923 36969 +46
==========================================
+ Hits 169625 169788 +163
+ Misses 11386 11366 -20
- Partials 7260 7300 +40
🚀 New features to boost your workflow:
|
Collaborator
lpinca
approved these changes
Jun 27, 2025
Collaborator
|
Landed in d824914 |
targos
pushed a commit
that referenced
this pull request
Jul 3, 2025
PR-URL: #58848 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2025
PR-URL: #58848 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jul 24, 2025
PR-URL: #58848 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
Dir.prototype.path,ReadStream.prototype.autoClose, andWriteStream.prototype.autoClosegetters and setters throwERR_INVALID_THISinstead of failing with internal implementation-specific messages when called on invalidthis.