8000 test: fix `test-cluster-worker-kill` by santigimeno · Pull Request #5814 · nodejs/node · GitHub
  • [go: up one dir, main page]
    Skip to content

    test: fix test-cluster-worker-kill #5814

    New issue

    Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

    Sign up for GitHub

    By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

    Already on GitHub? Sign in to your account

    Jump to bottom
    Closed
    santigimeno wants to merge 1 commit into from
    Closed

    test: fix test-cluster-worker-kill #5814

    santigimeno wants to merge 1 commit into from

    Conversation

    @santigimeno
    Copy link
    Member
    @santigimeno santigimeno commented Mar 20, 2016

    Pull Request check-list

    Please make sure to review and check all of these items:

    • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
      this change (including linting)?
    • Is the commit message formatted according to CONTRIBUTING.md?

    Affected core subsystem(s)

    test

    Description of change

    Don't check that the disconnect event is emitted before the exit
    event as the order is not guaranteed.
    See failing test @ https://ci.nodejs.org/job/node-test-commit-linux/nodes=centos5-32/2648/tapTestReport/test.tap-133/

    not ok 133 test-cluster-worker-kill.js
# 
# assert.js:89
# throw new assert.AssertionError({
# ^
# AssertionError: worker: 'exit' event before 'disconnect' event
# at Worker.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/nodes/centos5-32/test/parallel/test-cluster-worker-kill.js:80:12)
# at Worker.g (events.js:273:16)
# at emitTwo (events.js:100:13)
# at Worker.emit (events.js:185:7)
# at ChildProcess.<anonymous> (cluster.js:361:14)
# at ChildProcess.g (events.js:273:16)
# at emitTwo (events.js:100:13)
# at ChildProcess.emit (events.js:185:7)
# at Process.ChildProcess._handle.onexit (internal/child_process.js:204:12)

    @cjihrig
    Copy link
    Contributor
    cjihrig commented Mar 20, 2016

    LGTM

    @santigimeno
    test: fix test-cluster-worker-kill
    5dae734 
    Don't check that the `disconnect` event is emitted before the `exit`
event as the order is not guaranteed.
    @santigimeno santigimeno force-pushed the fix-cluster-worker-kill branch from b43d365 to 5dae734 Compare March 20, 2016 20:47
    @jbergstroem
    Copy link
    Member
    jbergstroem commented Mar 20, 2016

    CI: https://ci.nodejs.org/job/node-test-commit/2604/
    8000

    @mscdex mscdex added cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests. labels Mar 20, 2016
    @jasnell
    Copy link
    Member
    jasnell commented Mar 21, 2016

    LGTM

    jasnell pushed a commit that referenced this pull request Mar 21, 2016
    @santigimeno @jasnell
    test: fix test-cluster-worker-kill
    8d39481 
    Don't check that the `disconnect` event is emitted before the `exit`
event as the order is not guaranteed.

PR-URL: #5814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @jasnell
    Copy link
    Member
    jasnell commented Mar 21, 2016

    Landed in 8d39481

    @Fishrock123 Fishrock123 mentioned this pull request Mar 22, 2016
    Merged
    Fishrock123 pushed a commit that referenced this pull request Mar 22, 2016
    @santigimeno @Fishrock123
    test: fix test-cluster-worker-kill
    d2fa644 
    Don't check that the `disconnect` event is emitted before the `exit`
event as the order is not guaranteed.

PR-URL: #5814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    MylesBorins pushed a commit that referenced this pull request Mar 30, 2016
    @santigimeno
    test: fix test-cluster-worker-kill
    02c364e 
    Don't check that the `disconnect` event is emitted before the `exit`
event as the order is not guaranteed.

PR-URL: #5814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    MylesBorins pushed a commit that referenced this pull request Mar 30, 2016
    @santigimeno
    test: fix test-cluster-worker-kill
    0a1eb16 
    Don't check that the `disconnect` event is emitted before the `exit`
event as the order is not guaranteed.

PR-URL: #5814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    jBarz added a commit to ibmruntimes/node that referenced this pull request Feb 19, 2017
    @jBarz
    test: fix test-cluster-worker-kill
    dae313d 
    cherry-pick following from master

commit 8d39481
Author: Santiago Gimeno <santiago.gimeno@gmail.com>
Date:   Sun Mar 20 21:11:36 2016 +0100

    test: fix `test-cluster-worker-kill`

    Don't check that the `disconnect` event is emitted before the `exit`
    event as the order is not guaranteed.

    PR-URL: nodejs/node#5814
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    No reviews

    Assignees

    No one assigned

    Labels

    cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests.

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    6 participants

    @santigimeno @cjihrig @jbergstroem @jasnell @mscdex @MylesBorins
    0