build: define python when generating out/Makefile
#57970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57970 +/- ##
==========================================
- Coverage 90.26% 89.73% -0.53%
==========================================
Files 630 630
Lines 186170 186170
Branches 36478 36164 -314
==========================================
- Hits 168042 167066 -976
- Misses 10982 11937 +955
- Partials 7146 7167 +21 🚀 New features to boost your workflow:
|
LiviaMedeiros
approved these changes
Apr 23, 2025
Collaborator
lpinca
approved these changes
Apr 23, 2025
Collaborator
Collaborator
|
Landed in c712dd2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #48462
Equal to
node/configure.py
Lines 2363 to 2372 in d74c498
When
out/Makefileis generated during./configure,-Dpython=is passed to GYP, however, when it's generated from the Makefile, it is not passed. This can lead to an undefined variable python on some systems.