build: add skip_apidoc_files and include QUIC #56941
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56941 +/- ##
=======================================
Coverage 89.11% 89.11%
=======================================
Files 665 665
Lines 193203 193203
Branches 37217 37214 -3
=======================================
+ Hits 172165 172177 +12
- Misses 13767 13769 +2
+ Partials 7271 7257 -14
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Feb 7, 2025
richardlau
reviewed
Feb 7, 2025
aduh95
reviewed
Feb 10, 2025
Member
|
It's still not quite in the correct order |
200b03f to
295289f
Compare
Collaborator
Member
|
@RafaelGSS can you rebase? |
|
Hi, Thank you to all the reviewers for their hard work. It seems that some tests have failed, but I’m interested in learning more about the details that need improvement or adjustment. Are there any additional steps we should take to address the remaining issues? I appreciate the updates and look forward to moving forward. Best regards, |
295289f to
db302e5
Compare
Collaborator
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/56941 ✔ Done loading data for nodejs/node/pull/56941 ----------------------------------- PR info ------------------------------------ Title build: add skip_apidoc_files and include QUIC (#56941) Author Rafael Gonzaga <rafael.nunu@hotmail.com> (@RafaelGSS) Branch RafaelGSS:hide-quic-documentation -> nodejs:main Labels build, needs-ci Commits 4 - build: add skip_apidoc_files and include QUIC - fixup! build: add skip_apidoc_files and include QUIC - fixup! fixup! build: add skip_apidoc_files and include QUIC - fixup! fixup! fixup! build: add skip_apidoc_files and include QUIC Committers 1 - RafaelGSS <rafael.nunu@hotmail.com> PR-URL: https://github.com/nodejs/node/pull/56941 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56941 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - build: add skip_apidoc_files and include QUIC ⚠ - fixup! build: add skip_apidoc_files and include QUIC ⚠ - fixup! fixup! build: add skip_apidoc_files and include QUIC ⚠ - fixup! fixup! fixup! build: add skip_apidoc_files and include QUIC ℹ This PR was created on Thu, 06 Feb 2025 17:27:17 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/56941#pullrequestreview-2600564603 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/56941#pullrequestreview-2607299515 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-02-17T21:11:35Z: https://ci.nodejs.org/job/node-test-pull-request/65280/ - Querying data for job/node-test-pull-request/65280/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13382384552 |
jasnell
pushed a commit
that referenced
this pull request
Feb 18, 2025
PR-URL: #56941 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Member
|
Landed in 0a4572d |
1 similar comment
This comment was marked as duplicate.
This comment was marked as duplicate.
acidiney
pushed a commit
to acidiney/node
that referenced
this pull request
Feb 23, 2025
PR-URL: nodejs#56941 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
targos
pushed a commit
that referenced
this pull request
Feb 24, 2025
PR-URL: #56941 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
targos
pushed a commit
that referenced
this pull request
Feb 25, 2025
PR-URL: #56941 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Member
Author
|
This commit didn't land cleanly on v22.x-staging. It requires a manual backport, so I'm adding a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we have discussed in TSC meeting
cc: @nodejs/tsc