8000 src: use `std::ranges::greater` instead of `std::greater` by targos · Pull Request #56844 · nodejs/node · GitHub
[go: up one dir, main page]
Skip to content

src: use std::ranges::greater instead of std::greater #56844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
targos wants to merge 1 commit into from
Closed

src: use std::ranges::greater instead of std::greater #56844

targos wants to merge 1 commit into from

Conversation

8000
@targos
Copy link
Member
@targos targos commented Jan 31, 2025 •
edited
Loading

Blind tentative to fix #56063 (comment)

Based on the example from https://en.cppreference.com/w/cpp/algorithm/ranges/sort

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jan 31, 2025
@targos
Copy link
Member Author
targos commented Jan 31, 2025

Doesn't fix it (the error is worse)

@targos targos closed this Jan 31, 2025
@targos targos deleted the targos-patch-1 branch January 31, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@targos @anonrig @nodejs-github-bot
0