stream: use nop as write() callback if omitted #564
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a nop function that is used as the Writable.prototype.write() callback when one is not provided. This saves on function and closure creation.
Contributor
There was a problem hiding this comment.
s/nop/noop/ ? I have only ever seen the latter.
Contributor
Author
There was a problem hiding this comment.
Yea, I personally prefer noop, but nop seems to be used in core too.
Member
|
LGTM but I suggest rewording this:
To:
Empty functions don't allocate a closure context (they don't close over anything) but they still create a function object (when passed around as values.) |
Contributor
Author
|
OK, I will reword it. |
cjihrig
added a commit
that referenced
this pull request
Jan 23, 2015
This commit introduces a nop function that is used as the Writable.prototype.write() callback when one is not provided. This saves on function object creation. PR-URL: #564 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Contributor
Author
|
Landed in 40ffed8 |
This was referenced Sep 13, 2021
This was referenced Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a nop function that is used as the
Writable.prototype.write()callback when one is not provided. This saves on function and closure creation.