8000 deps: V8: cherry-pick f915fa4c9f41 by legendecas · Pull Request #55484 · nodejs/node · GitHub
  • [go: up one dir, main page]
    Skip to content

    deps: V8: cherry-pick f915fa4c9f41 #55484

    New issue

    Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

    Sign up for GitHub

    By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

    Already on GitHub? Sign in to your account

    Jump to bottom
    Closed
    legendecas wants to merge 2 commits into from
    Closed

    deps: V8: cherry-pick f915fa4c9f41 #55484

    legendecas wants to merge 2 commits into from

    Conversation

    @legendecas
    Copy link
    Member
    @legendecas legendecas commented Oct 21, 2024

    deps: V8: cherry-pick f915fa4c9f41

    Original commit message:

    [osr] Ensure trying to osr does not skip loop interrupts

Fixed: 374013413
Change-Id: I52d7b4e165e0abd0bd517a81d2e8ef3f1f802bfb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5946288
Commit-Queue: Darius Mercadier <dmercadier@chromium.org>
Auto-Submit: Olivier Flückiger <olivf@chromium.org>
Reviewed-by: Darius Mercadier <dmercadier@chromium.org>
Cr-Commit-Position: refs/heads/main@{#96708}

    Refs: v8/v8@f915fa4

    test: add repl preview timeout test

    Fixes #54193

    @legendecas
    deps: V8: cherry-pick f915fa4c9f41
    553c94c 
    Original commit message:

    [osr] Ensure trying to osr does not skip loop interrupts

    Fixed: 374013413
    Change-Id: I52d7b4e165e0abd0bd517a81d2e8ef3f1f802bfb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5946288
    Commit-Queue: Darius Mercadier <dmercadier@chromium.org>
    Auto-Submit: Olivier Flückiger <olivf@chromium.org>
    Reviewed-by: Darius Mercadier <dmercadier@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#96708}

Refs: v8/v8@f915fa4
    @legendecas
    test: add repl preview timeout test
    d160567
    @nodejs-github-bot
    Copy link
    Collaborator
    nodejs-github-bot commented Oct 21, 2024

    Review requested:

    • @nodejs/gyp
    • @nodejs/security-wg
    • @nodejs/v8-update

    @nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Oct 21, 2024
    @nodejs-github-bot
    Copy link
    Collaborator
    nodejs-github-bot commented Oct 21, 2024

    V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6251/

    @nodejs-github-bot
    Copy link
    Collaborator
    nodejs-github-bot commented Oct 21, 2024

    V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6251/

    @nodejs-github-bot
    Copy link
    Collaborator
    nodejs-github-bot commented Oct 21, 2024

    V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6251/

    @legendecas legendecas added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v18.x labels Oct 21, 2024
    @richardlau richardlau added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Oct 21, 2024
    @legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2024
    @github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2024
    @nodejs-github-bot
    Copy link
    Collaborator
    nodejs-github-bot commented Oct 21, 2024

    CI: https://ci.nodejs.org/job/node-test-pull-request/63232/

    @nodejs-github-bot
    Copy link
    Collaborator
    nodejs-github-bot commented Oct 21, 2024

    V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6252/

    @nodejs-github-bot
    Copy link
    Collaborator
    nodejs-github-bot commented Oct 21, 2024

    V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6252/

    @nodejs-github-bot
    Copy link
    Collaborator
    nodejs-github-bot commented Oct 21, 2024

    V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6252/

    @codecov
    Copy link
    codecov bot commented Oct 21, 2024 •
    edited
    Loading

    Codecov Report

    All modified and coverable lines are covered by tests ✅

    Project coverage is 88.41%. Comparing base (6a02c27) to head (d160567).
    Report is 247 commits behind head on main.

    Additional details and impacted files 
    @@           Coverage Diff           @@
##             main   #55484   +/-   ##
=======================================
  Coverage   88.41%   88.41%           
=======================================
  Files         653      653           
  Lines      187421   187421           
  Branches    36071    36072    +1     
=======================================
+ Hits       165700   165707    +7     
+ Misses      14964    14956    -8     
- Partials     6757     6758    +1

    see 23 files with indirect coverage changes

    @nodejs-github-bot
    Copy link
    Collaborator
    nodejs-github-bot commented Oct 21, 2024

    CI: https://ci.nodejs.org/job/node-test-pull-request/63236/

    @richardlau richardlau added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 22, 2024
    @aduh95
    Copy link
    Contributor
    aduh95 commented Oct 22, 2024

    Any reason why 553c94c does not have the same author as v8/v8@f915fa4?

    @legendecas
    Copy link
    Member Author
    legendecas commented Oct 22, 2024 •
    edited
    Loading

    Any reason why 553c94c does not have the same author as v8/v8@f915fa4?

    I think git-node v8 backport re-commits the patch at https://github.com/nodejs/node-core-utils/blob/c953d93523cf2d88686e076f9abd4b661a9e8b0d/lib/update-v8/backport.js#L76 and the apply step didn't preserve the original author: https://github.com/nodejs/node-core-utils/blob/c953d93523cf2d88686e076f9abd4b661a9e8b0d/lib/update-v8/backport.js#L198

    @nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 23, 2024
    @nodejs-github-bot
    Copy link
    Collaborator
    nodejs-github-bot commented Oct 23, 2024

    Landed in c1bbd63...7b5d660

    nodejs-github-bot pushed a commit that referenced this pull request Oct 23, 2024
    @legendecas @nodejs-github-bot
    deps: V8: cherry-pick f915fa4c9f41
    f630fde 
    Original commit message:

    [osr] Ensure trying to osr does not skip loop interrupts

    Fixed: 374013413
    Change-Id: I52d7b4e165e0abd0bd517a81d2e8ef3f1f802bfb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5946288
    Commit-Queue: Darius Mercadier <dmercadier@chromium.org>
    Auto-Submit: Olivier Flückiger <olivf@chromium.org>
    Reviewed-by: Darius Mercadier <dmercadier@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#96708}

Refs: v8/v8@f915fa4
PR-URL: #55484
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    nodejs-github-bot pushed a commit that referenced this pull request Oct 23, 2024
    @legendecas @nodejs-github-bot
    test: add repl preview timeout test
    7b5d660 
    PR-URL: #55484
Refs: v8/v8@f915fa4
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @legendecas legendecas deleted the v8/repl-osr branch October 23, 2024 13:15
    aduh95 pushed a commit that referenced this pull request Oct 23, 2024
    @legendecas @aduh95
    deps: V8: cherry-pick f915fa4c9f41
    df2f1ad 
    Original commit message:

    [osr] Ensure trying to osr does not skip loop interrupts

    Fixed: 374013413
    Change-Id: I52d7b4e165e0abd0bd517a81d2e8ef3f1f802bfb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5946288
    Commit-Queue: Darius Mercadier <dmercadier@chromium.org>
    Auto-Submit: Olivier Flückiger <olivf@chromium.org>
    Reviewed-by: Darius Mercadier <dmercadier@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#96708}

Refs: v8/v8@f915fa4
PR-URL: #55484
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    aduh95 pushed a commit that referenced this pull request Oct 23, 2024
    @legendecas @aduh95
    test: add repl preview timeout test
    4dc2791 
    PR-URL: #55484
Refs: v8/v8@f915fa4
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @aduh95 aduh95 mentioned this pull request Oct 24, 2024
    Merged
    louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
    @legendecas @louwers
    deps: V8: cherry-pick f915fa4c9f41
    ba99119 
    Original commit message:

    [osr] Ensure trying to osr does not skip loop interrupts

    Fixed: 374013413
    Change-Id: I52d7b4e165e0abd0bd517a81d2e8ef3f1f802bfb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5946288
    Commit-Queue: Darius Mercadier <dmercadier@chromium.org>
    Auto-Submit: Olivier Flückiger <olivf@chromium.org>
    Reviewed-by: Darius Mercadier <dmercadier@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#96708}

Refs: v8/v8@f915fa4
PR-URL: nodejs#55484
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
    @legendecas @louwers
    test: add repl preview timeout test
    bada9d0 
    PR-URL: nodejs#55484
Refs: v8/v8@f915fa4
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
    @legendecas @tpoisseau
    deps: V8: cherry-pick f915fa4c9f41
    e852a8d 
    Original commit message:

    [osr] Ensure trying to osr does not skip loop interrupts

    Fixed: 374013413
    Change-Id: I52d7b4e165e0abd0bd517a81d2e8ef3f1f802bfb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5946288
    Commit-Queue: Darius Mercadier <dmercadier@chromium.org>
    Auto-Submit: Olivier Flückiger <olivf@chromium.org>
    Reviewed-by: Darius Mercadier <dmercadier@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#96708}

Refs: v8/v8@f915fa4
PR-URL: nodejs#55484
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tpoisseau pushed a commit to tpoisseau/node that referenced this pull request Nov 21, 2024
    @legendecas @tpoisseau
    test: add repl preview timeout test
    42e06e1 
    PR-URL: nodejs#55484
Refs: v8/v8@f915fa4
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @ruyadorno
    Copy link
    Member
    ruyadorno commented Nov 27, 2024

    This commit does not land cleanly on v22.x-staging and will need manual backport in case we want it in v22.x.

    @ruyadorno ruyadorno added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label Nov 27, 2024
    @BridgeAR BridgeAR mentioned this pull request Apr 23, 2025
    Closed
    @aduh95 aduh95 removed the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label May 19, 2025
    @aduh95 aduh95 mentioned this pull request May 19, 2025
    Merged
    aduh95 pushed a commit that referenced this pull request May 19, 2025
    @legendecas @aduh95
    deps: V8: cherry-pick f915fa4c9f41
    8339d9b 
    Original commit message:

    [osr] Ensure trying to osr does not skip loop interrupts

    Fixed: 374013413
    Change-Id: I52d7b4e165e0abd0bd517a81d2e8ef3f1f802bfb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5946288
    Commit-Queue: Darius Mercadier <dmercadier@chromium.org>
    Auto-Submit: Olivier Flückiger <olivf@chromium.org>
    Reviewed-by: Darius Mercadier <dmercadier@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#96708}

Refs: v8/v8@f915fa4
PR-URL: #55484
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    aduh95 pushed a commit that referenced this pull request May 19, 2025
    @legendecas @aduh95
    test: add repl preview timeout test
    fd37891 
    PR-URL: #55484
Refs: v8/v8@f915fa4
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @ghost ghost mentioned this pull request Jun 8, 2025
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Reviewers

    @lpinca lpinca lpinca approved these changes

    @richardlau richardlau richardlau approved these changes

    Assignees

    No one assigned

    Labels

    author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

    Projects

    None yet

    Milestone

    No milestone

    Development

    Successfully merging this pull request may close these issues.

    Node.js REPL freezes with "while (true);" or "while (true){}" input

    6 participants

    @legendecas @nodejs-github-bot @aduh95 @ruyadorno @lpinca @richardlau
    0