8000 dgram: add UV_UDP_REUSEPORT for udp by theanarkh · Pull Request #55403 · nodejs/node · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@theanarkh
Copy link
Contributor
@theanarkh theanarkh commented Oct 16, 2024

UV_UDP_REUSEPORT allows users to bind a port to multiple sockets.
Refs: libuv/libuv#4419

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dgram Issues and PRs related to the dgram subsystem / UDP. needs-ci PRs that need a full CI run. labels Oct 16, 2024
@theanarkh theanarkh force-pushed the add_reuseport_for_udp branch from 023beb9 to be29823 Compare October 16, 2024 11:33
Copy link
Member
@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 16, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 16, 2024
@nodejs-github-bot
Copy link
Collaborator

@codecov
Copy link
codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (7a7c2b3) to head (c563569).
Report is 68 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55403      +/-   ##
==========================================
- Coverage   88.41%   88.40%   -0.02%     
==========================================
  Files         652      653       +1     
  Lines      186878   187491     +613     
  Branches    36061    36094      +33     
==========================================
+ Hits       165236   165751     +515     
- Misses      14895    14970      +75     
- Partials     6747     6770      +23     
Files with missing lines Coverage Δ
lib/dgram.js 97.33% <100.00%> (+0.01%) ⬆️
src/udp_wrap.cc 78.71% <100.00%> (+0.04%) ⬆️

... and 119 files with indirect coverage changes

@theanarkh theanarkh force-pushed the add_reuseport_for_udp branch from be29823 to cc1cc30 Compare October 16, 2024 13:29
@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 16, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 16, 2024
@nodejs-github-bot
Copy link
Collaborator

@theanarkh theanarkh force-pushed the add_reuseport_for_udp branch 2 times, most recently from 249aa05 to 67bc2db Compare October 16, 2024 18:11
@nodejs-github-bot
Copy link
Collaborator