10BC0 test: add coverage for webstorage quota by jakecastelli · Pull Request #53964 · nodejs/node · GitHub
[go: up one dir, main page]
Skip to content

test: add coverage for webstorage quota #53964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakecastelli wants to merge 2 commits into from
Closed

test: add coverage for webstorage quota #53964

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c44e668
test: add coverage for webstorage quota
jakecastelli Jul 20, 2024
70490d4
fixup! improve test
jakecastelli Jul 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 37 additions & 1 deletion test/parallel/test-webstorage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const tmpdir = require('../common/tmpdir');
const assert = require('node:assert');
const { join } = require('node:path');
const { readdir } = require('node:fs/promises');
const { test } = require('node:test');
const { test, describe } = require('node:test');
const { spawnPromisified } = common;
let cnt = 0;

Expand Down Expand Up @@ -109,3 +109,39 @@ test('localStorage is persisted if it is used', async () => {
assert.strictEqual(cp.code, 0);
assert.match(cp.stdout, /barbaz/);
});


describe('webstorage quota for localStorage and sessionStorage', () => {
const MAX_STORAGE_SIZE = 10 * 1024 * 1024;

test('localStorage can store and retrieve a max of 10 MB quota', async () => {
const localStorageFile = nextLocalStorage();
const cp = await spawnPromisified(process.execPath, [
'--experimental-webstorage',
'--localstorage-file', localStorageFile,
// Each character is 2 bytes
'-pe', `
localStorage['a'.repeat(${MAX_STORAGE_SIZE} / 2)] = '';
console.error('filled');
localStorage.anything = 'should fail';
`,
]);

assert.match(cp.stderr, /filled/);
assert.match(cp.stderr, /QuotaExceededError: Setting the value exceeded the quota/);
});

test('sessionStorage can store a max of 10 MB quota', async () => {
const cp = await spawnPromisified(process.execPath, [
'--experimental-webstorage',
// Each character is 2 bytes
'-pe', `sessionStorage['a'.repeat(${MAX_STORAGE_SIZE} / 2)] = '';
console.error('filled');
sessionStorage.anything = 'should fail';
`,
]);

assert.match(cp.stderr, /filled/);
assert.match(cp.stderr, /QuotaExceededError/);
});
});
0