8000 src: use Maybe<void> in SecureContext by tniessen · Pull Request #53883 · nodejs/node · GitHub
[go: up one dir, main page]
Skip to content

src: use Maybe<void> in SecureContext #53883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nodejs-github-bot merged 1 commit into from
Jul 19, 2024
Merged

src: use Maybe<void> in SecureContext #53883

nodejs-github-bot merged 1 commit into from
Jul 19, 2024

Conversation

@tniessen
Copy link
Member
@tniessen tniessen commented Jul 17, 2024

With recent versions of V8, it is not necessary to use Maybe<bool> anymore. This changes member functions of SecureContext to use Maybe<void> instead.

Two of the relevant functions oddly return Just(false) in some cases. There is clearly some proper error handling missing in these functions, so I've added some TODO comments.

@tniessen
src: use Maybe<void> in SecureContext
e117b5a 
With recent versions of V8, it is not necessary to use Maybe<bool>
anymore. This changes member functions of SecureContext to use
Maybe<void> instead.
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 17, 2024
@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Jul 17, 2024

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Jul 17, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 17, 2024
@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Jul 17, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/60387/

@tniessen tniessen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 17, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 19, 2024
@nodejs-github-bot nodejs-github-bot merged commit cd39578 into nodejs:main Jul 19, 2024
@nodejs-github-bot
Copy link
Collaborator
nodejs-github-bot commented Jul 19, 2024

Landed in cd39578

targos pushed a commit that referenced this pull request Jul 28, 2024
@tniessen @targos
src: use Maybe<void> in SecureContext
9ffaf76 
With recent versions of V8, it is not necessary to use Maybe<bool>
anymore. This changes member functions of SecureContext to use
Maybe<void> instead.

PR-URL: #53883
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jul 30, 2024
Merged
@marco-ippolito marco-ippolito added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tniessen @nodejs-github-bot @addaleax @lpinca @anonrig @marco-ippolito
0