test: add missing cctest/test_path.cc #52148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
Contributor
|
Fast-track has been requested by @anonrig. Please 👍 to approve. |
richardlau
approved these changes
Mar 19, 2024
GeoffreyBooth
approved these changes
Mar 19, 2024
Collaborator
Member
Author
|
It seems the existing tests are failing. cc @RafaelGSS @nodejs/platform-windows |
atlowChemi
approved these changes
Mar 19, 2024
Trott
approved these changes
Mar 19, 2024
Contributor
|
It looks like |
Contributor
|
The reason behind this is the I see that those test cases are taken from |
06e0270 to
d7dd131
Compare
Member
Author
|
Thank you @StefanStojanovic. Updated the pull-request. |
Collaborator
Collaborator
Collaborator
Collaborator
Collaborator
lpinca
approved these changes
Mar 20, 2024
Collaborator
|
Landed in 0b67673 |
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 26, 2024
PR-URL: nodejs#52148 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito
pushed a commit
that referenced
this pull request
May 2, 2024
PR-URL: #52148 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
marco-ippolito
pushed a commit
that referenced
this pull request
May 3, 2024
PR-URL: #52148 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't running and testing test_path.cc. This change ensures that
make cctestruns the test file.cc @RafaelGSS @nodejs/path