fs: improve error performance for fdatasyncSync
#49898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
approved these changes
Sep 27, 2023
Collaborator
joyeecheung
reviewed
Sep 27, 2023
Member
There was a problem hiding this comment.
I don't think we should introduce a seemingly new implementation by copying and repeating the original implementation & moving code to a new JS file which makes git blame harder to use. See #49593 (comment)
31 tasks
Member
|
Hey @pluris can you rebase this pull request? You'll see that |
358c67e to
78b27c0
Compare
Contributor
Author
Member
Contributor
Author
|
@anonrig I updated the description. |
Member
|
The benchmark you're running doesn't exist in main or in your pull request. Can you add the file to your pull request? :-) @pluris |
Contributor
Author
|
@anonrig Oh, sorry. I added it again. |
anonrig
approved these changes
Oct 1, 2023
Collaborator
Contributor
Author
|
Oops, there was a part where the condition check was missing, so I modified it again and updated the benchmark. |
Contributor
Author
|
@joyeecheung GetValidatedFd() has also been removed here, as described in #49880 (explanation). |
joyeecheung
approved these changes
Oct 2, 2023
Collaborator
18 tasks
anonrig
approved these changes
Oct 3, 2023
Collaborator
14 tasks
Collaborator
|
Landed in f7a160d |
This was referenced Oct 5, 2023
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49898 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #49898 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
debadree25
pushed a commit
to debadree25/node
that referenced
this pull request
Apr 15, 2024
PR-URL: nodejs#49898 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/performance#106